[pull] master from kevoreilly:master#317
Merged
pull[bot] merged 2 commits intothreatcode:masterfrom Oct 23, 2025
Merged
Conversation
* Allow .pcapng files to be generated at download-time, in addition to during processing Generating .pcapng files during processing results in double the amount of network data being stored on disk. This is because the original .pcap is required for reprocessing. This change introduces functionality that enables .pcapng files to be generated when the file download is attempted (when the file is required). This brings two benefits: 1. PCAP-NG files aren't generated for every detonation, reducing the amount of disk space used. 2. Reduces processing time. It's worth noting that the tradeoff is that it can be quite expensive to generate the .pcapng in the web thread if the PCAP is significant in size. * Refactor PcaptoNg __init__ function Initialize variables in a more robust fashion. Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> * Move utils.pcap to lib.cuckoo.common.pcap_utils --------- Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )