-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
test: add new Maestro tests #10136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
test: add new Maestro tests #10136
Conversation
coreycb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VladLucaci I added a couple of comments. Can you take a look?
It would also be good if we could add explanations to the commit message for existing tests that were updated.
| @@ -1,56 +1,50 @@ | |||
| appId: net.thunderbird.android.debug | |||
| appId: net.thunderbird.android.beta | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the appId's remain debug or is there a good reason to switch to beta?
| #### Open display settings | ||
| #- tapOn: | ||
| # id: "android:id/title" | ||
| # index: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a lot of yaml commented out throughout these files. Is that expected?
I've submitted this on behalf of @VladLucaci