Skip to content

Commit edc9f81

Browse files
committed
Use more informative function names
1 parent bc47ac6 commit edc9f81

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

R/utilities.R

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1259,11 +1259,11 @@ check_if_assays_are_NOT_consistently_ordered <- function(se) {
12591259
check_if_assays_are_NOT_overlapped <- function(se, dim = "cols") {
12601260
stopifnot(dim %in% c("rows", "cols"))
12611261
if (dim == "rows") {
1262-
namefcn <- rownames
1263-
dimfcn <- nrow
1262+
dimnames_function <- rownames
1263+
length_function <- nrow
12641264
} else {
1265-
namefcn <- colnames
1266-
dimfcn <- ncol
1265+
dimnames_function <- colnames
1266+
length_function <- ncol
12671267
}
12681268

12691269
# If I have any assay at all
@@ -1274,7 +1274,7 @@ check_if_assays_are_NOT_overlapped <- function(se, dim = "cols") {
12741274
Negate(is.null),
12751275
assays(se, withDimnames = FALSE) |>
12761276
as.list() |>
1277-
map(namefcn)
1277+
map(dimnames_function)
12781278
) |>
12791279
length() |>
12801280
gt(0) &&
@@ -1283,10 +1283,10 @@ check_if_assays_are_NOT_overlapped <- function(se, dim = "cols") {
12831283
# This will be TRUE also if some assays have dimnames and other don't
12841284
assays(se, withDimnames = FALSE) |>
12851285
as.list() |>
1286-
map(namefcn) |>
1286+
map(dimnames_function) |>
12871287
reduce(intersect) |>
12881288
length() |>
1289-
equals(dimfcn(se)) |>
1289+
equals(length_function(se)) |>
12901290
not()
12911291
}
12921292

0 commit comments

Comments
 (0)