feat(installed): Standardize install and session lifecycle #228
+613
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bump schema_version from 1 to 2 - Add opt_out field to InstallState (defaults to false via serde) - Change client_id from static "nori-cli" to deterministic UUID - Implement generate_client_id() using SHA256 hash of "nori_salt:hostname:username" - Format client_id as UUID: 8-4-4-4-12 (matches JS/Python implementation) - Update new_first_install() to accept client_id parameter - Maintain backward compatibility: v1 state files deserialize correctly - All tests pass (36/36)
…ing, and flat event schema Analytics Opt-Out: - Add NORI_NO_ANALYTICS environment variable (highest priority) - State file opt_out field respected (defaults to false) - State file still updates even when opted out Session ID: - Generate ephemeral UUID for each process run - Pass to all analytics events via session_id field - Never persisted to disk User Resurrection: - Detect when last_launched_at > 30 days ago - Send user_resurrected event before main event - Resurrection event has same properties as session_start Flat Event Schema: - New FlatEventRequest structure: event, client_id, session_id, timestamp, properties - Event names: app_install, app_update, session_start, user_resurrected - EventProperties: version, os, arch, is_ci - Replaces nested event_params structure - Analytics endpoint: https://noriskillsets.dev/api/analytics/track - Timeout reduced to 5 seconds All tests pass (43/43)
- Remove @current-session markers from 12 permanent tests - Delete test_generate_client_id_uses_nori_salt (tests implementation detail rather than behavior) - Remaining tests validate real behavior and API contracts
Collaborator
Author
|
Closing in favor of #226 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.