tc-functions: bug fix in getMajorVer #89
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if full version is 17alpha1 (for example), getMajorVer outputs 17alpha1. Bug fix is so that getMajorVer outputs 17 in this example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if full version is 17alpha1 (for example), getMajorVer outputs 17alpha1 rather than 17 as expected. Downstream from this bug, getMirror sets the MIRROR variable to the nonexistent url http://repo.tinycorelinux.net/17alpha1.x/x86_64/tcz (rather than the expected http://repo.tinycorelinux.net/17.x/x86_64/tcz), breaking tce-update and update-everything, among others. With this bug fix, getMajorVer always outputs the expected major version -> MIRROR is set to correct url -> everybody's happy :)