drivers.Pin with function pointers example#774
Closed
ysoldak wants to merge 1 commit intotinygo-org:drivers-pin-interfacefrom
Closed
drivers.Pin with function pointers example#774ysoldak wants to merge 1 commit intotinygo-org:drivers-pin-interfacefrom
ysoldak wants to merge 1 commit intotinygo-org:drivers-pin-interfacefrom
Conversation
ysoldak
commented
Jul 6, 2025
|
|
||
| type PinOut interface { | ||
| High() // deprecated: use Set(true) | ||
| Low() // deprecated: use Set(false) |
Contributor
Author
There was a problem hiding this comment.
I'd prefer we do not have these in the interface and sweep and eradicate call to them everywhere in drivers.
ysoldak
commented
Jul 6, 2025
| ResetPin drivers.PinOut | ||
| DataPin drivers.PinOut | ||
| ChipSelectPin drivers.PinOut | ||
| BusyPin drivers.PinIn |
Contributor
Author
There was a problem hiding this comment.
Showcase use of PinOut and PinIn interfaces.
Contributor
|
This is pulled from a PR we agreed to not continue with at the moment. The design of #753 leaves us open for this design in the future if we so desire to go on with it. |
Member
|
Closing now that #795 was merged. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This showcases how we can split
drivers.Pinto smallerdrivers.PinInanddrivers.PinOutinterfaces AND use function pointer to.Set(bool)function in performance critical places, likesoftspiimplementation.This still breaks users though, as it is based on a PR #749 that mandates pins to be configured outside the drivers.