Skip to content

Conversation

@kemister85
Copy link
Contributor

@kemister85 kemister85 commented Apr 24, 2025

Ticket: DOC-3202
Ticket: TINY-12035

Site: Staging branch-migration-from-4x/
Site: Staging branch-migration-from-5x/

Changes:

  • Add new guides to assist users wanting to migrate from v4 and v5 version of TinyMCE.

Pre-checks:

  • Branch prefixed with feature/<version>/, hotfix/<version>/, staging/<version>/, or release/<version>/.
  • modules/ROOT/nav.adoc has been updated (if applicable).

Review:

  • Documentation Team Lead has reviewed

kemister85 and others added 2 commits May 14, 2025 13:57
Co-authored-by: shirqa <43625458+ShiridiGandham@users.noreply.github.com>
Co-authored-by: shirqa <43625458+ShiridiGandham@users.noreply.github.com>
@mhideo
Copy link
Contributor

mhideo commented May 19, 2025

I've reviewed this for tone against the notion pages that Arvin wrote. Looks good to me.

Copy link
Contributor

@mhideo mhideo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against tone and the content Arvin wrote in notion. Ready to ship from my perspective. Would like to get Product and GTM behind this as well.

Copy link
Contributor

@mhideo mhideo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against tone and the content Arvin wrote in notion. Ready to ship from my perspective. Would like to get Product and GTM behind this as well.

Copy link
Contributor

@mhideo mhideo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed against tone and the content Arvin wrote in notion. Ready to ship from my perspective. Would like to get Product and GTM behind this as well.

Copy link
Member

@lostkeys lostkeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! The overall language and depth is correct IMHO. Just have some minor things about reviewing certain details that applies to both guides.

@kemister85 kemister85 requested a review from lostkeys May 21, 2025 10:46
@kemister85 kemister85 marked this pull request as ready for review May 21, 2025 22:55
@kemister85 kemister85 requested review from a team, abhinavgandham and soritaheng as code owners May 21, 2025 22:55
Copy link
Contributor

@ShiridiGandham ShiridiGandham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kemister85 kemister85 merged commit 07f40d1 into tinymce/7 May 27, 2025
5 checks passed
@kemister85 kemister85 deleted the hotfix/7/DOC-3202 branch May 27, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants