-
Notifications
You must be signed in to change notification settings - Fork 221
DOC-3202: Add migration guides for users migrating from TinyMCE 4 | 5 to v7
#3691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: shirqa <43625458+ShiridiGandham@users.noreply.github.com>
Co-authored-by: shirqa <43625458+ShiridiGandham@users.noreply.github.com>
|
I've reviewed this for tone against the notion pages that Arvin wrote. Looks good to me. |
mhideo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed against tone and the content Arvin wrote in notion. Ready to ship from my perspective. Would like to get Product and GTM behind this as well.
mhideo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed against tone and the content Arvin wrote in notion. Ready to ship from my perspective. Would like to get Product and GTM behind this as well.
mhideo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed against tone and the content Arvin wrote in notion. Ready to ship from my perspective. Would like to get Product and GTM behind this as well.
lostkeys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good! The overall language and depth is correct IMHO. Just have some minor things about reviewing certain details that applies to both guides.
…nd clarify default changes for TinyMCE 7.0
ShiridiGandham
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket: DOC-3202
Ticket: TINY-12035
Site: Staging branch-migration-from-4x/
Site: Staging branch-migration-from-5x/
Changes:
Pre-checks:
feature/<version>/,hotfix/<version>/,staging/<version>/, orrelease/<version>/.modules/ROOT/nav.adochas been updated(if applicable).Review: