bug(tsql): fix datepart handling when part is quoted#6934
Merged
georgesittas merged 1 commit intotobymao:mainfrom Feb 3, 2026
Merged
bug(tsql): fix datepart handling when part is quoted#6934georgesittas merged 1 commit intotobymao:mainfrom
georgesittas merged 1 commit intotobymao:mainfrom
Conversation
georgesittas
approved these changes
Feb 3, 2026
georgesittas
pushed a commit
that referenced
this pull request
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous discussion here
Summary - while this doesn't seem valid, this is a legitimate TSQL syntax (escaping date parts).
It's already supported in
dateadd&datediff, but was missing fromdatepart.Validated here as well with
select datepart("dd",'2025-12-13')on SQL Server 2022-- more details
trust me, I don't like this being a valid syntax neither, but it is :)
the above is a valid TSQL syntax.
Also - note that you guys already support this syntax in other date functions:
is parsed into: