feat(optimizer)!: Moved SIN, COS, TAN, COT to Base#6936
Merged
georgesittas merged 1 commit intotobymao:mainfrom Feb 3, 2026
Merged
feat(optimizer)!: Moved SIN, COS, TAN, COT to Base#6936georgesittas merged 1 commit intotobymao:mainfrom
SIN, COS, TAN, COT to Base#6936georgesittas merged 1 commit intotobymao:mainfrom
Conversation
georgesittas
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to #6911
This PR refactors the
SIN,COS,TAN,COTfunction by moving it to the base dialectWe have explicitly retained the existing logic for Snowflake and T-SQL.
Question:
Hive do not support
COT, but now it is annotating it asDOUBLEas we moved it to base, will it be fine?