Skip to content

Answer:63#1439

Open
geromegrignon wants to merge 1 commit intotomalaforge:mainfrom
geromegrignon:forms-custom-forms
Open

Answer:63#1439
geromegrignon wants to merge 1 commit intotomalaforge:mainfrom
geromegrignon:forms-custom-forms

Conversation

@geromegrignon
Copy link

✅ Challenge Submission Checklist

Start your PR title with: Answer:${challenge_number}

⚠️ Important Notice

If you would like personal feedback or a detailed review, please support the project on GitHub:

You can also submit a PR without sponsorship to:

  • Be listed among the answered challenges, or
  • Receive a review from a community member. 🔥

Comments

  • 21.2 version will enhance the form submission with the formRootdirective so we do not have to use novalidate + event.preventDefault()
  • having a reusable component for multiple fields make the FormValueControl API quite useless because you can only bind to the parent FieldState for inputs and you need a custom input to get the whole FieldState: it adds contraints without benefits
  • Errors in templates is still a nightmare and even worse: we now have an array without having a .getErrorto easily identify an error. Forms will be full of computed SIgnals to access target errors.
  • we still have to couple invalid + touched/dirty state manually to display errors at the right time for a good user experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant