fix: Fix incorrect use of pk_attr instead of db_pk_column when using RelationalField as the primary key#1362
Open
tufbel wants to merge 2 commits intotortoise:developfrom
Open
fix: Fix incorrect use of pk_attr instead of db_pk_column when using RelationalField as the primary key#1362tufbel wants to merge 2 commits intotortoise:developfrom
tufbel wants to merge 2 commits intotortoise:developfrom
Conversation
…RelationalField as the primary key.
…n using RelationalField(pk=True).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using
RelationalField(pk=True)without specifyingsource_field, the value ofmeta.db_pk_columnis the same asmeta.pk_attr. Theoretically, the value ofmeta.db_pk_columnshould bef"{meta.db_pk_column}_id".Fix the issue where the
pkfilter condition is not available when usingRelationalField(pk=True).Motivation and Context
I would like
meta.db_pk_columnto be recognized correctly when usingRelationalField(pk=True).How Has This Been Tested?
Checklist: