refactor: remove pytz and use standard library zoneinfo#2023
Open
waketzheng wants to merge 13 commits intotortoise:developfrom
Open
refactor: remove pytz and use standard library zoneinfo#2023waketzheng wants to merge 13 commits intotortoise:developfrom
pytz and use standard library zoneinfo#2023waketzheng wants to merge 13 commits intotortoise:developfrom
Conversation
Pull Request Test Coverage Report for Build 21782611814Details
💛 - Coveralls |
|
0.25.3 nothing changed |
Contributor
Author
@ockan This PR does not merge to develop branch yet. And it's a breaking change, will not release at 0.25.x, may be 0.26.0 or higher version (not promise) |
Contributor
Author
|
Before these PRs merged, you can use the slim branch for clean deps: uv pip install -U "tortoise-orm @git+ssh://git@github.com/tortoise/tortoise-orm@slim"
# Or by http:
#uv pip install -U "tortoise-orm @git+https://github.com/tortoise/tortoise-orm@slim"This branch only depends on pypika-tortoise |
Member
|
Is there any reason to keep pytz as even optional dependency? |
pytz and use standard library zoneinfo
Contributor
Author
Seem that is better to remove it. I updated code and add some tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
zoneinfo, which can be used to replace pytzMotivation and Context
Reduce dependency suggested by #1956
How Has This Been Tested?
make ci
Checklist:
My change requires a change to the documentation.I have updated the documentation accordingly.