Skip to content

Update chamada.js #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
guiasis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update chamada.js #13

guiasis wants to merge 1 commit into from

Conversation

@guiasis
Copy link

@guiasis guiasis commented Jun 10, 2020

Bugfix in chamada.js

dilowagner
dilowagner suggested changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@dilowagner dilowagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito obrigado pela ajuda @guiasis
Mas acredito que por questão de compatibilidade, seria interessante usarmos o padrão do Object.assign
que já está sendo utilizado no Post TTS

Mais uma vez, muito obrigado pela contribuição

@dilowagner
Copy link
Contributor

dilowagner commented Jun 16, 2020

Já estamos pensando em atualizar essa lib para uma versão 2.0 hehe ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dilowagner dilowagner dilowagner requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guiasis @dilowagner