Loosen types for Reactant #162
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great package. I use it for a bunch of research. Right now, I am working to adapt my code to use
Reactantso I can take advantage of various accelerators. One of Reactant's quirks is that it requires pretty generous type annotations. The base structures areTracedRNumbers <: NumberandTracedRArray <: AbstractArray. If I want to useTransformVariableswithReactant. I sadly need to widen some of the type annotations.This is a draft PR that uses one method to make it compatible with Reactant, but I am very open to suggestions!
There are still some issues with this PR, including the scalar indexing, which will require some additional thought.