-
Notifications
You must be signed in to change notification settings - Fork 867
chore(deps-dev): bump the gha group across 1 directory with 4 updates #3576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps-dev): bump the gha group across 1 directory with 4 updates #3576
Conversation
Bumps the gha group with 4 updates in the /packages/opentelemetry-instrumentation-replicate directory: [replicate](https://github.com/replicate/replicate-python), [pytest-sugar](https://github.com/Teemu/pytest-sugar), [ruff](https://github.com/astral-sh/ruff) and [vcrpy](https://github.com/kevin1024/vcrpy). Updates `replicate` from 0.26.1 to 1.0.7 - [Release notes](https://github.com/replicate/replicate-python/releases) - [Commits](replicate/replicate-python@0.26.1...1.0.7) Updates `pytest-sugar` from 1.0.0 to 1.1.1 - [Release notes](https://github.com/Teemu/pytest-sugar/releases) - [Changelog](https://github.com/Teemu/pytest-sugar/blob/main/CHANGES.rst) - [Commits](Teemu/pytest-sugar@v1.0.0...v1.1.1) Updates `ruff` from 0.14.11 to 0.14.12 - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](https://github.com/astral-sh/ruff/commits) Updates `vcrpy` from 6.0.2 to 7.0.0 - [Release notes](https://github.com/kevin1024/vcrpy/releases) - [Changelog](https://github.com/kevin1024/vcrpy/blob/master/docs/changelog.rst) - [Commits](kevin1024/vcrpy@v6.0.2...v7.0.0) --- updated-dependencies: - dependency-name: replicate dependency-version: 1.0.7 dependency-type: direct:development update-type: version-update:semver-major dependency-group: gha - dependency-name: pytest-sugar dependency-version: 1.1.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: gha - dependency-name: ruff dependency-version: 0.14.12 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: gha - dependency-name: vcrpy dependency-version: 7.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: gha ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 73024e7 in 3 minutes and 49 seconds. Click for details.
- Reviewed
1968lines of code in2files - Skipped
0files when reviewing. - Skipped posting
7draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/opentelemetry-instrumentation-replicate/pyproject.toml:20
- Draft comment:
Bump 'pytest-sugar' from 1.0.0 to 1.1.1. Verify that the updated terminal reporter signature (per 1.1.1 release) does not break our instrumentation or test framework. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. packages/opentelemetry-instrumentation-replicate/pyproject.toml:27
- Draft comment:
Update the 'replicate' dependency constraint from '<0.27.0' to '<1.1.0'. Ensure that the breaking API changes in replicate v1.0.7 (e.g. return type in run()) are handled in our instrumentation. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment is about a dependency version change that was made in the diff. However, the comment doesn't identify a specific problem in the code - it's asking the author to "ensure" that breaking changes are handled. This is exactly the type of comment the rules say to avoid: "Do NOT ask the PR author to confirm their intention, to explain, to double-check things, to ensure the behavior is intended". The comment is speculative - it assumes there might be breaking changes that need handling, but doesn't point to actual code that needs to be fixed. If there were actual breaking changes that needed to be addressed, the comment should point to specific code that needs to change, not just ask the author to verify. Maybe the comment is valid because major version bumps (0.x to 1.x) often do contain breaking changes, and this could be important to verify. Perhaps the tool has specific knowledge about breaking changes in replicate v1.0.7 that would affect the instrumentation code. Even if there are known breaking changes in replicate v1.0.7, the comment should point to specific code in this PR that needs to be changed, not just ask the author to "ensure" things are handled. Without pointing to actual code that needs fixing, this is just a verification request which violates the rules. If the instrumentation code actually needs changes, those should be identified specifically. This comment should be deleted because it asks the PR author to "ensure" something is handled rather than pointing to specific code that needs to be changed. It's a verification/confirmation request which violates the rules for review comments.
3. packages/opentelemetry-instrumentation-replicate/pyproject.toml:28
- Draft comment:
Increase the upper bound for 'vcrpy' from <7 to <8. Confirm that vcrpy 7.0.0 (with its breaking changes and dropped Python 3.8 support) is compatible with our environment. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the author to confirm compatibility with a new version of a dependency, which is not allowed according to the rules. It does not provide a specific suggestion or point out a specific issue with the code.
4. packages/opentelemetry-instrumentation-replicate/uv.lock:1
- Draft comment:
Lock file revision increased from 1 to 3. Ensure these auto-generated updates (hashes, upload times) are correct and solely reflect the dependency updates. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to ensure that the auto-generated updates in the lock file are correct. This falls under the category of asking the author to double-check things, which is against the rules. The comment does not provide a specific suggestion or point out a specific issue.
5. packages/opentelemetry-instrumentation-replicate/uv.lock:870
- Draft comment:
Updated 'replicate' package from 0.26.1 to 1.0.7. Double-check that our instrumentation adapts to replicate's breaking API changes (e.g. run() now returns FileObjects). - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to double-check the adaptation to breaking API changes, which violates the rule against asking the author to double-check things. It does not provide a specific suggestion or ask for a specific test to be written.
6. packages/opentelemetry-instrumentation-replicate/uv.lock:995
- Draft comment:
Bump 'ruff' from 0.14.11 to 0.14.12. Review its changelog for any linting rule modifications that might require code adjustments. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is related to a dependency change, specifically a version bump for therufflibrary. The comment suggests reviewing the changelog for any linting rule modifications. According to the rules, comments on pure dependency changes or library versions should be ignored. Therefore, this comment should be removed.
7. packages/opentelemetry-instrumentation-replicate/uv.lock:1020
- Draft comment:
Upgraded 'vcrpy' from 6.0.2 to 7.0.0. Verify that changes (including dropped support or API changes) do not negatively impact our VCR-based tests. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the PR author to verify that the upgrade of a dependency does not negatively impact the tests. This falls under the rule of not asking the author to ensure the behavior is intended or to double-check things. Therefore, this comment should be removed.
Workflow ID: wflow_wfg4jnLA4e18hKAI
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Bumps the gha group with 4 updates in the /packages/opentelemetry-instrumentation-replicate directory: replicate, pytest-sugar, ruff and vcrpy.
Updates
replicatefrom 0.26.1 to 1.0.7Release notes
Sourced from replicate's releases.
... (truncated)
Commits
42ba2f7Release 1.0.736c95a8format and lint48acf51Update replicate/client.py68551cfLinting302f5daMake scope lookup case insensitive52c373cDocument alternative authenticationab9982fSupport getting REPLICATE_API_TOKEN from cog context9f8d753bump to 1.0.6f5d53cdbump patch to 1.0.5804fd1dfix(package): include py.typed marker fileUpdates
pytest-sugarfrom 1.0.0 to 1.1.1Release notes
Sourced from pytest-sugar's releases.
Changelog
Sourced from pytest-sugar's changelog.
Commits
8133503Release pytest-sugar 1.1.16798042Fix conflict with other Pytest plugins (#297)43bbdd0Release pytest-sugar 1.1.0855d661Feature - Playwright Support for Trace Zip Mapping (#296)2a5862aMerge pull request #293 from cgoldberg/add-py313ca26d98Add support for Python 3.1369989ebClarify license as BSD 3-Clause License3c86a5cMerge pull request #289 from deronnax/remove-packaging-depc123be0remove 'packaging' packageefafd9cMerge pull request #282 from penguinpee/mainUpdates
rufffrom 0.14.11 to 0.14.12Changelog
Sourced from ruff's changelog.
Commits
Updates
vcrpyfrom 6.0.2 to 7.0.0Release notes
Sourced from vcrpy's releases.
Changelog
Sourced from vcrpy's changelog.
... (truncated)
Commits
3278619Release v7.0.03fb62e0fix: correctly handle asyncio.run when loop exists8197865build(deps): update sphinx requirement from <8 to <9be651bdpre-commit: Autoupdatea6698edFix aiohttp tests48d0a2eFixed missingversion_stringattribute when used with urllib3>=2.3.05b858b1Fix lintc8d99a9Fix ruff configurationce27c63Merge pull request #736 from kevin1024/drop-python38ab8944dDrop python 3.8 supportDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsImportant
Bump
replicate,pytest-sugar,ruff, andvcrpydependencies in/packages/opentelemetry-instrumentation-replicatedirectory.replicatefrom 0.26.1 to 1.0.7 inpyproject.tomlanduv.lock.pytest-sugarfrom 1.0.0 to 1.1.1 inpyproject.tomlanduv.lock.rufffrom 0.14.11 to 0.14.12 inpyproject.tomlanduv.lock.vcrpyfrom 6.0.2 to 7.0.0 inpyproject.tomlanduv.lock.This description was created by
for 73024e7. You can customize this summary. It will automatically update as commits are pushed.