-
Notifications
You must be signed in to change notification settings - Fork 869
chore(deps-dev): bump the gha group across 1 directory with 4 updates #3581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps-dev): bump the gha group across 1 directory with 4 updates #3581
Conversation
Bumps the gha group with 4 updates in the /packages/opentelemetry-instrumentation-haystack directory: [haystack-ai](https://github.com/deepset-ai/haystack), [pytest-sugar](https://github.com/Teemu/pytest-sugar), [ruff](https://github.com/astral-sh/ruff) and [vcrpy](https://github.com/kevin1024/vcrpy). Updates `haystack-ai` from 2.3.1 to 2.21.0 - [Release notes](https://github.com/deepset-ai/haystack/releases) - [Commits](deepset-ai/haystack@v2.3.1...v2.21.0) Updates `pytest-sugar` from 1.0.0 to 1.1.1 - [Release notes](https://github.com/Teemu/pytest-sugar/releases) - [Changelog](https://github.com/Teemu/pytest-sugar/blob/main/CHANGES.rst) - [Commits](Teemu/pytest-sugar@v1.0.0...v1.1.1) Updates `ruff` from 0.14.11 to 0.14.12 - [Release notes](https://github.com/astral-sh/ruff/releases) - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md) - [Commits](https://github.com/astral-sh/ruff/commits) Updates `vcrpy` from 6.0.2 to 7.0.0 - [Release notes](https://github.com/kevin1024/vcrpy/releases) - [Changelog](https://github.com/kevin1024/vcrpy/blob/master/docs/changelog.rst) - [Commits](kevin1024/vcrpy@v6.0.2...v7.0.0) --- updated-dependencies: - dependency-name: haystack-ai dependency-version: 2.21.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: gha - dependency-name: pytest-sugar dependency-version: 1.1.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: gha - dependency-name: ruff dependency-version: 0.14.12 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: gha - dependency-name: vcrpy dependency-version: 7.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: gha ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to b678713 in 1 minute and 43 seconds. Click for details.
- Reviewed
26lines of code in1files - Skipped
1files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/opentelemetry-instrumentation-haystack/pyproject.toml:32
- Draft comment:
Bumped pytest-sugar to 1.1.1 in the dev group. Confirm compatibility with your pytest plugins. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is related to a dependency change, specifically bumping the version ofpytest-sugar. The comment asks the PR author to confirm compatibility with pytest plugins, which is a form of asking for confirmation and ensuring behavior, violating the rules.
2. packages/opentelemetry-instrumentation-haystack/pyproject.toml:37
- Draft comment:
Changed haystack-ai range from '<2.4' to '<2.22'. Verify that restricting to 2.21.x is intentional. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 0% vs. threshold = 50% This comment is asking the PR author to verify/confirm their intention with the version change. According to the rules, I should "Do NOT ask the PR author to confirm their intention, to explain, to double-check things, to ensure the behavior is intended" - this directly violates that rule. The comment doesn't point out a specific bug or issue, it's just asking for confirmation. The change from <2.4 to <2.22 appears to be expanding the allowed version range, which seems reasonable. There's no evidence of an actual problem here. Could there be a legitimate concern that version 2.22 might introduce breaking changes? Perhaps the comment is trying to prevent a potential compatibility issue that I'm not aware of without seeing the rest of the codebase. Even if there could be compatibility concerns, the comment doesn't identify any specific issue - it just asks for verification. This is exactly the type of "confirm your intention" comment that the rules say to avoid. If there were actual breaking changes in 2.22, the comment should state that specifically rather than asking for verification. This comment should be deleted because it asks the PR author to verify their intention, which directly violates the review rules. It doesn't identify any specific problem or provide actionable feedback.
3. packages/opentelemetry-instrumentation-haystack/pyproject.toml:40
- Draft comment:
Bumped pytest-sugar to 1.1.1 in the test group for consistency. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative and does not provide any actionable feedback or suggestions. It simply states that a dependency version was updated for consistency, which is not within the scope of useful comments according to the rules.
4. packages/opentelemetry-instrumentation-haystack/pyproject.toml:42
- Draft comment:
Updated vcrpy range to '<8' (from '<7') to allow v7.0.0. Confirm integration remains stable. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is about a dependency change, specifically updating the version range forvcrpy. The comment asks to confirm integration stability, which is against the rules as it asks the author to ensure behavior is intended or tested. Therefore, this comment should be removed.
Workflow ID: wflow_DvXpX2ETGKq8rjgp
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
|
Looks like these dependencies are updatable in another way, so this is no longer needed. |
Bumps the gha group with 4 updates in the /packages/opentelemetry-instrumentation-haystack directory: haystack-ai, pytest-sugar, ruff and vcrpy.
Updates
haystack-aifrom 2.3.1 to 2.21.0Release notes
Sourced from haystack-ai's releases.
... (truncated)
Commits
ffe5e47bump version to 2.21.008a82c8bump version to 2.21.0-rc1ecce6f6chore: small improvements SentenceWindowRetriever08b979cSync Haystack API reference on Docusaurus (#10188)bad2937feat: add run async filter and automerging retriever (#9897)dfd678eImprove flaky tool invocation integration test (#10187)152a16cFix flaky parallel tool test with stronger model (#10183)251335fSync Haystack API reference on Docusaurus (#10185)adcd4aechore: Update Azure default model to gpt-4.1-mini (#10167)0907d89docs: new page that documents pipeline loops (#10134)Updates
pytest-sugarfrom 1.0.0 to 1.1.1Release notes
Sourced from pytest-sugar's releases.
Changelog
Sourced from pytest-sugar's changelog.
Commits
8133503Release pytest-sugar 1.1.16798042Fix conflict with other Pytest plugins (#297)43bbdd0Release pytest-sugar 1.1.0855d661Feature - Playwright Support for Trace Zip Mapping (#296)2a5862aMerge pull request #293 from cgoldberg/add-py313ca26d98Add support for Python 3.1369989ebClarify license as BSD 3-Clause License3c86a5cMerge pull request #289 from deronnax/remove-packaging-depc123be0remove 'packaging' packageefafd9cMerge pull request #282 from penguinpee/mainUpdates
rufffrom 0.14.11 to 0.14.12Changelog
Sourced from ruff's changelog.
Commits
Updates
vcrpyfrom 6.0.2 to 7.0.0Release notes
Sourced from vcrpy's releases.
Changelog
Sourced from vcrpy's changelog.
... (truncated)
Commits
3278619Release v7.0.03fb62e0fix: correctly handle asyncio.run when loop exists8197865build(deps): update sphinx requirement from <8 to <9be651bdpre-commit: Autoupdatea6698edFix aiohttp tests48d0a2eFixed missingversion_stringattribute when used with urllib3>=2.3.05b858b1Fix lintc8d99a9Fix ruff configurationce27c63Merge pull request #736 from kevin1024/drop-python38ab8944dDrop python 3.8 supportDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsImportant
Bump versions of
haystack-ai,pytest-sugar,ruff, andvcrpyinpyproject.tomlforopentelemetry-instrumentation-haystack.haystack-aifrom2.3.1to2.21.0.pytest-sugarfrom1.0.0to1.1.1.rufffrom0.14.11to0.14.12.vcrpyfrom6.0.2to7.0.0.pyproject.tomlinpackages/opentelemetry-instrumentation-haystack.This description was created by
for b678713. You can customize this summary. It will automatically update as commits are pushed.