-
Notifications
You must be signed in to change notification settings - Fork 7
Add precommit hooks via prek and default ruff/pytest configuration #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
f537826
feat: enhance cookiecutter template with stricter standards
dguido c975cb8
feat: add FastAPI as preferred web framework option
dguido f6dee7f
Merge branch 'main' into enhance-cookiecutter-standards
dguido 6fa0b6a
fix: correct ty version and remove unsupported --strict flag
dguido 517395b
fix: apply ruff formatting to pre_gen_project.py
dguido 08fb765
refactor: remove data library option from cookiecutter
dguido e805061
refactor: simplify PR by removing FastAPI and consolidating config
dguido 330cbb9
fix: restore 'reformat' target as alias to fix CI
dguido 2fbd39b
fix: correct license field syntax in pyproject.toml
dguido d405f81
fix: correct ty configuration field name
dguido d481298
fix: remove ty configuration section to use defaults
dguido 2902ab9
test commit
dguido 67244e8
refactor: replace ty with pyright and improve configurations
dguido a249f00
test commit
dguido 0030cef
fix: address all code review issues
dguido d7c9bbf
Fix the PR
DarkaMaul 08e45c6
Update Makefile
DarkaMaul c335fc3
Merge
DarkaMaul 3726689
Update the pre-commit
DarkaMaul d414c4d
Replace pre-commit with prek
DarkaMaul 0593a47
Tests run on pre-push
Ninja3047 c53210e
pin pyright
Ninja3047 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| # Pre-commit hooks for code quality | ||
| # Uses prek (https://github.com/j178/prek) - a faster pre-commit alternative | ||
| repos: | ||
| - repo: builtin | ||
| hooks: | ||
| - id: trailing-whitespace | ||
| - id: end-of-file-fixer | ||
| - id: check-yaml | ||
| - id: check-toml | ||
| - id: check-merge-conflict | ||
| - id: detect-private-key | ||
|
|
||
| - repo: local | ||
| hooks: | ||
| - id: format | ||
| name: format code | ||
| entry: make format | ||
| language: system | ||
| types: [python] | ||
| pass_filenames: false | ||
|
|
||
| - id: lint | ||
| name: lint code | ||
| entry: make lint | ||
| language: system | ||
| types: [python] | ||
| pass_filenames: false | ||
| require_serial: true | ||
|
|
||
| - id: test | ||
| name: run tests | ||
| entry: make test | ||
| language: system | ||
| types: [python] | ||
| pass_filenames: false | ||
| require_serial: true | ||
| stages: [pre-push] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.