Skip to content

Conversation

@kvz
Copy link
Member

@kvz kvz commented Nov 26, 2025

No description provided.

@kvz kvz merged commit 25441d0 into main Nov 26, 2025
7 checks passed
@kvz kvz deleted the sync-alphalib-2025-11-26 branch November 26, 2025 19:29
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1 to +3
import type { GlobOptionsWithoutFileTypes } from 'node:fs'
import * as fs from 'node:fs'
import { glob as fsGlob, stat as statAsync } from 'node:fs/promises'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid Node 20-incompatible fs.glob usage

The new nativeGlobby helper imports glob/globSync from node:fs/promises/node:fs, but those exports only landed in Node 22 while package.json still declares support for Node >=20. Loading this module on the currently supported Node 20.x will fail at module evaluation with The requested module 'node:fs/promises' does not provide an export named 'glob', so any future use of nativeGlobby will crash on the minimum supported runtime unless the engine constraint is raised or a fallback is added.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants