Modernize transloadify #60
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvz
changed the title
- Upgrade node-watch, recursive-readdir, image-size, rimraf, fakefile, request - Remove Q promise library in favor of native async/await and fs/promises - Update tests to use modern async/await syntax - Fix image-size API change (now requires Uint8Array) - Remove @types/q and Q from tsconfig.json types 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
kvz
changed the title
Convert all source files and tests from JavaScript to TypeScript with strict typing. Uses tsx for runtime execution, zod for runtime validation schemas, and IOutputCtl interface pattern for test dependency injection. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Leverage alphalib/tryCatch to simplify try-catch blocks in: - bills.ts - notifications.ts - templates.ts (get, delete, sync functions) - assemblies.ts (get, delete, replay functions) This removes the need for let declarations before try blocks and makes the code flow more linear. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add tsconfig.build.json for building to dist/ - Update package.json with prepack script, exports, and bin paths - Change bin/cmd.ts shebang from tsx to node - Lower Node engine requirement from >=22 to >=20 - Move dotenv to dependencies (needed at runtime) - Move tsx to devDependencies (only for development) - Remove obsolete cli.test.js (tested old Parser.js) - Add dist/ and tsbuildinfo to .gitignore Now `npm pack` / `npm publish` will include transpiled JS that works on Node 20+ without tsx. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Simplifies dist output - all files now in dist/ root instead of dist/bin/ and dist/src/. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Closing in favor of: transloadit/node-sdk#268 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: