Fix missing compile scope dependencies in released POM #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaorimatz
force-pushed
the
missing-compile-scope-dependencies
branch
from
6e65644 to
c0effc6
Compare
kaorimatz
changed the title
aamine
approved these changes
Mar 25, 2025
aamine
left a comment
aamine
left a comment
There was a problem hiding this comment.
I wonder if we really need shade jar, but LGTM for this change.
Member
Author
|
Thank you both for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compile scope dependencies are missing from the released POM since 0.9.7. e.g. https://repo1.maven.org/maven2/com/treasuredata/client/td-client/0.9.7/td-client-0.9.7.pom
This was caused by the maven-shade-plugin update in #192. Previously, maven-shade-plugin did not create the dependency reduced POM when shadedArtifactAttached was enabled, but in 3.3.0 the behavior changes and the plugin creates the dependency reduced POM regardless of the shadedArtifactAttached setting (MSHADE-321).
The problem is that the plugin not only creates the dependency reduced POM but also modifies the current project model to use the generated POM, which affects subsequent Maven executions (MSHADE-419).
As a workaround, we can stop creating the dependency reduced POM by disabling createDependencyReducedPom.