Add header params to getResult #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ganmacs
force-pushed
the
add-header-pramas-to-jobResult
branch
from
5a255bb to
33a3c96
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR extends the job result retrieval capabilities by adding a new header parameter to the getResult API call.
- Adds an overloaded jobResult method in TDClientApi to accept a boolean includeHeader.
- Implements the new method in TDClient, passing header information as a query parameter.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/com/treasuredata/client/TDClientApi.java | Adds an overloaded API method with a new includeHeader parameter and updated Javadoc comments. |
| src/main/java/com/treasuredata/client/TDClient.java | Implements the new method by forwarding to the underlying engine with the header parameter. |
Comments suppressed due to low confidence (2)
src/main/java/com/treasuredata/client/TDClientApi.java:293
- Please provide a description for the includeHeader parameter to clarify its effect on the API call.
* @param includeHeader
src/main/java/com/treasuredata/client/TDClientApi.java:294
- Please elaborate the @return documentation to indicate what the caller should expect from the method, particularly when an empty stream is received.
* @return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://api-docs.treasuredata.com/pages/td-api/tag/Jobs/#tag/Jobs/operation/getJobResults