Use T::from instead of cast where expected to be lossless. #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petesmc
force-pushed
the
clippy_cast_lossless
branch
2 times, most recently
from
46eea01 to
fd0e007
Compare
petesmc
force-pushed
the
clippy_cast_lossless
branch
from
fd0e007 to
02ee2a6
Compare
folkertdev
requested changes
Jan 5, 2026
Member
folkertdev
left a comment
folkertdev
left a comment
There was a problem hiding this comment.
I'd prefer to only apply this change only to the parts of the code that we've already cleaned up manually. Let's start with lib/dictBuilder. Can you
- remove changes to the other subdirectories from the initial commit
- fix the other comments I've left in a separate commit (that is easier to review)
| let mut candidateDictBuffer: Box<[u8]> = Box::from(vec![0u8; dictBufferCapacity]); | ||
| let regressionTolerance = | ||
| params.shrinkDictMaxRegression as core::ffi::c_double / 100.0f64 + 1.00f64; | ||
| core::ffi::c_double::from(params.shrinkDictMaxRegression) / 100.0f64 + 1.00f64; |
Member
There was a problem hiding this comment.
We should import use core::ffi::c_double so we can use it unqualified here.
Member
There was a problem hiding this comment.
same in the other files for the other core::ffi types.
| assert!(T[(s - 1) as usize] as i32 <= T[s as usize] as i32); | ||
| assert_eq!(i32::from(T[s as usize]), c1); | ||
| assert!( | ||
| (s + 1) < n && i32::from(T[s as usize]) <= i32::from(T[(s + 1) as usize]) |
Member
There was a problem hiding this comment.
I think the cast is just not needed here (c2rust introduces it to exactly match the C semantics, but we can just compare u8s here.
| #[cfg_attr(feature = "export-symbols", export_name = crate::prefix!(ZDICT_isError))] | ||
| pub extern "C" fn ZDICT_isError(errorCode: size_t) -> core::ffi::c_uint { | ||
| ERR_isError(errorCode) as _ | ||
| ERR_isError(errorCode).into() |
Member
There was a problem hiding this comment.
I'd prefer c_uint::from here.
| // look backward | ||
| let mut length_2 = MINMATCHLENGTH; | ||
| while (length_2 >= MINMATCHLENGTH) as core::ffi::c_int & (start > 0) as core::ffi::c_int != 0 { | ||
| while core::ffi::c_int::from(length_2 >= MINMATCHLENGTH) & core::ffi::c_int::from(start > 0) |
Member
There was a problem hiding this comment.
this can be simplified into length_2 >= MINMATCHLENGTH && start > 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix lints from
clippy::cast_lossless