Skip to content

Conversation

@petesmc
Copy link
Contributor

@petesmc petesmc commented Dec 25, 2025

Using the definitions in zstd.h, marked the relevant functions as deprecated in the code and where possible added the since and note tags.

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
test-aarch64-apple-darwin 33.19% <100.00%> (-0.24%) ⬇️
test-aarch64-unknown-linux-gnu 31.67% <100.00%> (-0.04%) ⬇️
test-i686-unknown-linux-gnu 31.72% <100.00%> (-0.04%) ⬇️
test-x86_64-unknown-linux-gnu 33.45% <100.00%> (+0.50%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
lib/compress/zstd_compress.rs 37.47% <ø> (-1.28%) ⬇️
lib/decompress/zstd_decompress.rs 63.90% <ø> (+1.85%) ⬆️
lib/decompress/zstd_decompress_block.rs 76.39% <ø> (ø)
lib/dictBuilder/zdict.rs 78.83% <100.00%> (-2.27%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!


#[deprecated(
since = "1.5.6",
note = "For debugging only, will be replaced by [`ZSTD_extractSequences`]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rustdoc link does not work in this position currently.

rust-lang/rust#98342

I kind of think that it should though, so this is just a note.

}

#[deprecated(
since = "1.5.6",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These versions are zstd versions, not versions of this crate. It kind of looks fine though, and it seems like a good way to preserve and present this information.

@folkertdev
Copy link
Member

I think we should just blanket allow the use of deprecated functions in our test crate. Also this needs a rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants