-
-
Notifications
You must be signed in to change notification settings - Fork 2
Add deprecated attributes modelled off zstd.h definitions #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 🚀 New features to boost your workflow:
|
folkertdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks!
|
|
||
| #[deprecated( | ||
| since = "1.5.6", | ||
| note = "For debugging only, will be replaced by [`ZSTD_extractSequences`]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rustdoc link does not work in this position currently.
I kind of think that it should though, so this is just a note.
| } | ||
|
|
||
| #[deprecated( | ||
| since = "1.5.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These versions are zstd versions, not versions of this crate. It kind of looks fine though, and it seems like a good way to preserve and present this information.
|
I think we should just blanket allow the use of deprecated functions in our test crate. Also this needs a rebase. |
Using the definitions in
zstd.h, marked the relevant functions as deprecated in the code and where possible added thesinceandnotetags.