Fixes the disabled state for the Switch component

[samejr]

Fixes the disabled state for the Switch component.

• The mouse pointer behaves correctly
• The hover states for both active and disabled are correct now

Summary by CodeRabbit

• Style
  • Enhanced the switch component’s visual feedback and accessibility for disabled states with updated hover effects, text color adjustments, and refined cursor behavior.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 8fb6426

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The pull request updates the styling and behavior of the switch component in the web application. Changes include modifications to hover states, particularly for disabled elements, with updated background and text colors. Additionally, the tertiary/small variation now includes an extra class for disabled states, and the label element receives cursor behavior classes to better reflect its interactivity when disabled. There are no changes to the exported or public declarations.

Changes

File

Change Summary

apps/.../components/primitives/Switch.tsx

Updated switch styling: the small container's hover state for disabled elements now uses hover:disabled:bg-charcoal-700 and disabled:hover:text-rose-500 instead of previous colors. The default text color is changed to text-text-dimmed. In the tertiary/small variation, an extra disabled-state class is added. The label element now includes cursor-pointer and group-disabled:cursor-not-allowed classes.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant S as SwitchComponent
    participant C as CSS Engine

    U->>S: Hover over switch
    S->>C: Evaluate state
    alt Disabled State
        C-->>S: Apply classes: hover:disabled:bg-charcoal-700, disabled:hover:text-rose-500, group-disabled:cursor-not-allowed
    else Enabled State
        C-->>S: Apply default hover and text classes (text-text-dimmed)
    end

Loading

Poem

Hopping through the code with glee,
I saw the switch so spiffy and free,
Disabled states now wear a bolder hue,
With hover magic that feels brand new,
A crunchy style update that makes me jump—whoo! 🐰✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f4ef008 and 8fb6426.

📒 Files selected for processing (1)

• apps/webapp/app/components/primitives/Switch.tsx (3 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: units / 🧪 Unit Tests
• GitHub Check: typecheck / typecheck
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (3)

apps/webapp/app/components/primitives/Switch.tsx (3)

10-10: Better visual feedback for disabled states, well done!

The updated hover styles for the disabled switch provide clearer visual feedback to users. Using hover:disabled:bg-charcoal-700 instead of transparent background and disabled:hover:text-rose-500 for text effectively communicates the disabled state while still responding to hover interactions.

---

31-34: Good improvement for tertiary/small variation's disabled state

Adding group-disabled:group-hover:text-text-dimmed ensures consistent text appearance when hovering over a disabled switch. This maintains the visual hierarchy and prevents the text from incorrectly brightening when the component is disabled.

---

70-75: Appropriate cursor behaviors for better UX

Adding cursor-pointer and group-disabled:cursor-not-allowed to the label element improves the user experience by providing appropriate cursor feedback. This change ensures that the cursor behavior matches the interactive state of the component, which aligns with the PR objective to fix the disabled state's mouse pointer behavior.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.