Highlight queues when concurrency limit reached and new table col by samejr · Pull Request #2008 · triggerdotdev/trigger.dev

samejr · 2025-05-01T15:16:36Z

Updates to the queues page:

Adds a new column for "Environment limit" or "user limit" and a tooltip to explain what it means
Highlights a row in orange if the max concurrency for that queue has been hit
Highlights the environment number and Running number if the concurrency limit has been reached
Uses the compact number component in BigNumber.tsx to abbreviates long numbers

Summary by CodeRabbit

New Features
- Added support for compact formatting of large numbers in metrics, with tooltips to display full values.
- Introduced a "Running" metric and improved concurrency limit indicators on the queues page, including a new "Limited by" column and enhanced status badges.
Style
- Updated layout and styling for metric displays and queue status indicators for improved clarity and visibility.
Bug Fixes
- Adjusted tooltip and badge colors for better status indication.
Documentation
- Improved tooltip explanations for concurrency limits.

…s hit

… text

…ompact Also includes some responsive improvements to make sure things wrap when it gets tight

changeset-bot · 2025-05-01T15:16:41Z

⚠️ No Changeset found

Latest commit: 1e391e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-05-01T15:16:43Z

Caution

Review failed

The pull request is closed.

Walkthrough

The changes introduce enhancements to the BigNumber metric component, adding support for conditional compact formatting with tooltips for large values. The component's layout and styling are updated, and a new prop allows specifying a threshold for compact display. In the queues page, a new "Running" metric is added, and the display logic for concurrency limits is refined with conditional styling, badges, and explanatory tooltips. Table headers and columns are updated for clarity, and button icon colors are adjusted for consistency. Minor import reordering is performed in the AnimatedNumber component.

Changes

File(s)	Change Summary
`apps/webapp/app/components/metrics/BigNumber.tsx`	Enhanced BigNumber to support a `compactThreshold` prop for conditional compact formatting. Updated layout to flex column, replaced title with `Header3`, added tooltip for compact numbers, and refined animation and formatting logic.
`apps/webapp/app/components/primitives/AnimatedNumber.tsx`	Reordered imports from "framer-motion", moving `animate` to the front and removing `useSpring`. No functional changes.
`apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx`	Added "Running" BigNumber metric with conditional styling and suffix. Updated concurrency limit display with warning styling and badges when at limit. Changed table headers and added "Limited by" column with tooltips. Adjusted button icon colors and minor tooltip text. No backend or data logic changes.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant QueuesPage
    participant BigNumber
    participant Tooltip

    User->>QueuesPage: Visit Queues Page
    QueuesPage->>BigNumber: Render metric (value, compactThreshold)
    BigNumber->>BigNumber: Check if value > compactThreshold
    alt Should compact
        BigNumber->>Tooltip: Wrap compact value with tooltip (full value)
        Tooltip-->>User: Show full value on hover
    else No compact
        BigNumber->>User: Show normal value (animated if enabled)
    end
    QueuesPage->>User: Display table with updated headers, badges, and tooltips

Possibly related PRs

Highlight queues when concurrency limit reached and new table col #2008: Also modifies the BigNumber component to add conditional compact formatting with a compactThreshold prop and updates its layout and rendering logic, indicating a direct and strong code-level connection.

Suggested reviewers

matt-aitken

Poem

In the land of numbers, big and bold,
Now compact stories are smartly told.
Tooltips whisper secrets clear,
While badges and warnings appear.
Queues march on, limits in sight—
The rabbit hops with UI delight!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0921c5c and 1e391e2.

📒 Files selected for processing (1)

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx (8 hunks)

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…rency-limit-reached # Conflicts: # apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx

samejr added 7 commits April 30, 2025 15:08

Combines the Running and Concurrency limit cols into 1

335ef6b

Display a badge when a queue is at the concurrency limit

56f4c23

Colors the Running/Limit column text amber if the concurrency limit i…

dfc5c59

…s hit

Turns the “Running” big number amber and shows “At concurrency limit”…

92835f1

… text

BigNumber now handles big values using formatNumber and formatNumberC…

b25c064

…ompact Also includes some responsive improvements to make sure things wrap when it gets tight

Adds a new col for showing how the queue is limited

7daa774

Reinstates a threshold for making very big numbers compact

0921c5c

samejr added 2 commits May 1, 2025 17:17

Merge remote-tracking branch 'origin/main' into highlight-when-concur…

a2ea3aa

…rency-limit-reached # Conflicts: # apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx

Added border to make the search bar not float

1e391e2

matt-aitken approved these changes May 1, 2025

View reviewed changes

matt-aitken merged commit 0fe85ea into main May 1, 2025
11 checks passed

matt-aitken deleted the highlight-when-concurrency-limit-reached branch May 1, 2025 16:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Highlight queues when concurrency limit reached and new table col#2008

Highlight queues when concurrency limit reached and new table col#2008
matt-aitken merged 9 commits intomainfrom
highlight-when-concurrency-limit-reached

samejr commented May 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented May 1, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 1, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

samejr commented May 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

samejr commented May 1, 2025 •

edited by coderabbitai bot

Loading

changeset-bot bot commented May 1, 2025 •

edited

Loading

coderabbitai bot commented May 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)