Changes the spinner in buttons to white now we have purple primary buttons

[samejr]

When we changed the primary button color to purple, the loading spinners when used inside some buttons also needed to change from "dark" to "white".

Summary by CodeRabbit

• Style
  • Updated the loading spinner color to white on the "Pause/Resume Environment" and "Upgrade to Pro" buttons for improved visual consistency.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 2118754

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

This update changes the color of the Spinner component used as a loading indicator in two different button components. In both cases, the Spinner's color is set to white instead of its previous value ("dark" or unspecified). No control flow, logic, or exported entity declarations are altered; the updates are strictly visual, affecting only the appearance of loading states in the relevant buttons.

Changes

File(s)	Change Summary
apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx	Sets Spinner color to white in the EnvironmentPauseResumeButton's submit button when loading.
apps/webapp/app/routes/resources.orgs.$organizationSlug.select-plan.tsx	Changes Spinner color to white in the "Upgrade to Pro" button's loading state within the TierPro dialog.

Possibly related PRs

• #1912: Both PRs modify the color of the spinner used as a loading indicator in button components to white, directly relating to the visual representation of loading states in buttons.
• #1828: Related to button styling and variants, including Pause Queue button, but does not alter Spinner color or the LeadingIcon prop.

Suggested reviewers

• matt-aitken

Poem

Spinners once spun in shades of night,
Now they whirl in brilliant white.
Buttons glow with loading cheer,
A subtle change, but oh so clear.
Rabbits hop with joy anew—
For every click, a brighter view!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2448242 and 2118754.

📒 Files selected for processing (2)

• apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx (1 hunks)
• apps/webapp/app/routes/resources.orgs.$organizationSlug.select-plan.tsx (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

apps/webapp/app/routes/resources.orgs.$organizationSlug.select-plan.tsx (1)

apps/webapp/app/components/primitives/Spinner.tsx (1)

• Spinner (8-62)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
• GitHub Check: typecheck / typecheck
• GitHub Check: units / 🧪 Unit Tests
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (2)

apps/webapp/app/routes/resources.orgs.$organizationSlug.select-plan.tsx (1)

681-681: Good visibility improvement!

Changing the spinner color to white provides better contrast against the purple primary button background in the "Upgrade to Pro" modal dialog, improving the loading state visibility.

apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.queues/route.tsx (1)

613-615: Nice consistency improvement!

Updating the spinner color to white for the environment pause/resume button ensures better contrast and maintains visual consistency with other button loading states in the application.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.