Delay reschedule fix (v3 & v4)

[matt-aitken]

Using runs.reschedule() wasn't working correctly.

• In v3 a bug was introduced when we added the TaskRun queueTimestamp column.
• In v4 it wasn't implemented yet

This PR makes rescheduling work properly for both versions.

[changeset-bot]

⚠️ No Changeset found

Latest commit: a583d3c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Walkthrough

The RescheduleTaskRunService class's call method was updated to modify its rescheduling logic based on the engine property of the task run. After updating the delayUntil field, the method now also sets a queueTimestamp field to the same value. The method then checks the engine type: if it is "V1", it calls EnqueueDelayedRunService.reschedule; otherwise, it invokes engine.rescheduleDelayedRun. An import for engine from "../runEngine.server" was added to support this conditional logic. No changes were made to the public interface of the class.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

apps/webapp/app/v3/services/rescheduleTaskRun.server.ts (1)

30-35: Await the engine reschedule for parity & add a default guard

Branch A (V1) waits for the reschedule to finish before returning, whereas Branch B returns the promise directly.
For consistent behaviour – especially if higher-level code relies on completion – await the engine call as well.
While touching this, a defensive default branch prevents silent no-ops when a new engine enum is introduced.

-    if (updatedRun.engine === "V1") {
-      await EnqueueDelayedRunService.reschedule(taskRun.id, delay);
-      return updatedRun;
-    } else {
-      return engine.rescheduleDelayedRun({ runId: taskRun.id, delayUntil: delay });
-    }
+    switch (updatedRun.engine) {
+      case "V1":
+        await EnqueueDelayedRunService.reschedule(taskRun.id, delay);
+        return updatedRun;
+
+      default:
+        return await engine.rescheduleDelayedRun({
+          runId: taskRun.id,
+          delayUntil: delay,
+        });
+    }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f9e74b and a583d3c.

📒 Files selected for processing (1)

• apps/webapp/app/v3/services/rescheduleTaskRun.server.ts (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

apps/webapp/app/v3/services/rescheduleTaskRun.server.ts (2)

apps/webapp/app/v3/services/enqueueDelayedRun.server.ts (1)

• EnqueueDelayedRunService (9-109)

apps/webapp/app/v3/runEngine.server.ts (1)

• engine (9-9)

⏰ Context from checks skipped due to timeout of 90000ms (25)

• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (10, 10)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 10)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (9, 10)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 10)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 10)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 10)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 10)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 10)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 10)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 10)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
• GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
• GitHub Check: typecheck / typecheck
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (1)

apps/webapp/app/v3/services/rescheduleTaskRun.server.ts (1)

25-27: Verify new queueTimestamp column & migration before deploy
The update now persists both delayUntil and queueTimestamp to the same value.
Please ensure that:

1. queueTimestamp actually exists in the TaskRun model and the production database has been migrated; otherwise this call will throw at runtime.
2. The semantic difference between queuedAt (used elsewhere) and the new queueTimestamp is clear to future readers – consider adding a brief inline comment or consolidating the names if they represent the same concept.