chore(references): remove v3-catalog#2443
Conversation
|
WalkthroughThis change updates references from v3-catalog to hello-world across configuration and documentation. In .vscode/launch.json, five launch configurations switch cwd to references/hello-world. CONTRIBUTING.md revises manual testing/setup instructions, commands, paths, and example values to use hello-world, and removes Prisma migrate/deploy and generate steps in favor of running the trigger dev workflow. packages/cli-v3/CHANGELOG.md and packages/core/CHANGELOG.md update sample TypeORM DataSource snippets to use the hello-world database name. No code logic or public API signatures are altered. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
.vscode/launch.json (1)
58-72: Optional: align names with new target (nit).Consider renaming “Debug V3 Dev/Deploy/list-profiles/update/Management” to mention “hello-world” to match the cwd and reduce ambiguity.
CONTRIBUTING.md (4)
87-90: Fix missing slash in core package path (nit).“packages/core” → “/packages/core”.
Apply this diff:
-We use the `<root>/references/hello-world` subdirectory as a staging ground for testing changes to the SDK (`@trigger.dev/sdk` at `<root>/packages/trigger-sdk`), the Core package (`@trigger.dev/core` at `<root>packages/core`), the CLI (`trigger.dev` at `<root>/packages/cli-v3`) and the platform (The remix app at `<root>/apps/webapp`). The instructions below will get you started on using the `hello-world` for local development of Trigger.dev. +We use the `<root>/references/hello-world` subdirectory as a staging ground for testing changes to the SDK (`@trigger.dev/sdk` at `<root>/packages/trigger-sdk`), the Core package (`@trigger.dev/core` at `<root>/packages/core`), the CLI (`trigger.dev` at `<root>/packages/cli-v3`) and the platform (The remix app at `<root>/apps/webapp`). The instructions below will get you started on using the `hello-world` for local development of Trigger.dev.
95-96: Use proper link formatting to satisfy markdownlint MD034 (nit).Apply this diff:
-1. Visit http://localhost:3030 in your browser and create a new V3 project called "hello-world". +1. Visit <http://localhost:3030> in your browser and create a new V3 project called "hello-world".
156-156: Tighten phrasing (nit).“inside of” → “inside”.
Apply this diff:
-6. If you make any changes in the CLI/Core/SDK, you'll need to `CTRL+C` to exit the `dev` command and restart it to pickup changes. Any changes to the files inside of the `hello-world/src/trigger` dir will automatically be rebuilt by the `dev` command. +6. If you make any changes in the CLI/Core/SDK, you'll need to `CTRL+C` to exit the `dev` command and restart it to pickup changes. Any changes to the files inside the `hello-world/src/trigger` dir will automatically be rebuilt by the `dev` command.
159-163: Tone/clarity polish (nit).Avoid “Feel free to…”; be direct.
Apply this diff:
-9. Feel free to add additional files in `hello-world/src/trigger` to test out specific aspects of the system, or add in edge cases. +9. You can add additional files in `hello-world/src/trigger` to test specific aspects of the system or edge cases.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (71)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yamlreferences/bun-catalog/README.mdis excluded by!references/**references/v3-catalog/.env.exampleis excluded by!references/**references/v3-catalog/.gitignoreis excluded by!references/**references/v3-catalog/.uploadable-envis excluded by!references/**references/v3-catalog/README.mdis excluded by!references/**references/v3-catalog/package.jsonis excluded by!references/**references/v3-catalog/prisma/migrations/20240821142001_add_initial_schema/migration.sqlis excluded by!references/**references/v3-catalog/prisma/migrations/migration_lock.tomlis excluded by!references/**references/v3-catalog/prisma/schema/post.prismais excluded by!references/**references/v3-catalog/prisma/schema/schema.prismais excluded by!references/**references/v3-catalog/prisma/schema/user.prismais excluded by!references/**references/v3-catalog/prisma/sql/getUsersWithPosts.sqlis excluded by!references/**references/v3-catalog/src/clientUsage.tsis excluded by!references/**references/v3-catalog/src/db.tsis excluded by!references/**references/v3-catalog/src/env.tsis excluded by!references/**references/v3-catalog/src/kysely/types.tsis excluded by!references/**references/v3-catalog/src/management.tsis excluded by!references/**references/v3-catalog/src/queues.tsis excluded by!references/**references/v3-catalog/src/telemetry.tsis excluded by!references/**references/v3-catalog/src/tracer.tsis excluded by!references/**references/v3-catalog/src/trigger/batch.tsis excluded by!references/**references/v3-catalog/src/trigger/binaries.tsis excluded by!references/**references/v3-catalog/src/trigger/checkpoints.tsis excluded by!references/**references/v3-catalog/src/trigger/concurrency.tsis excluded by!references/**references/v3-catalog/src/trigger/crash.tsis excluded by!references/**references/v3-catalog/src/trigger/decorators.tsis excluded by!references/**references/v3-catalog/src/trigger/email.tsxis excluded by!references/**references/v3-catalog/src/trigger/emails/index.tsxis excluded by!references/**references/v3-catalog/src/trigger/idempotencyKeys.tsis excluded by!references/**references/v3-catalog/src/trigger/init.tsis excluded by!references/**references/v3-catalog/src/trigger/javascript-esm.mjsis excluded by!references/**references/v3-catalog/src/trigger/javascript.cjsis excluded by!references/**references/v3-catalog/src/trigger/lazyAttempts.tsis excluded by!references/**references/v3-catalog/src/trigger/logging.tsis excluded by!references/**references/v3-catalog/src/trigger/longRunning.tsis excluded by!references/**references/v3-catalog/src/trigger/maxDuration.tsis excluded by!references/**references/v3-catalog/src/trigger/nullByte.tsis excluded by!references/**references/v3-catalog/src/trigger/openai.mtsis excluded by!references/**references/v3-catalog/src/trigger/orm/index.tsis excluded by!references/**references/v3-catalog/src/trigger/other.tsis excluded by!references/**references/v3-catalog/src/trigger/performance.tsis excluded by!references/**references/v3-catalog/src/trigger/playwrightTask.tsis excluded by!references/**references/v3-catalog/src/trigger/prismaTasks.tsis excluded by!references/**references/v3-catalog/src/trigger/puppeteerTask.tsis excluded by!references/**references/v3-catalog/src/trigger/queues.tsis excluded by!references/**references/v3-catalog/src/trigger/retries.tsis excluded by!references/**references/v3-catalog/src/trigger/returnTypes.tsis excluded by!references/**references/v3-catalog/src/trigger/runMetadata.tsis excluded by!references/**references/v3-catalog/src/trigger/scheduled.tsis excluded by!references/**references/v3-catalog/src/trigger/sdkUsage.tsis excluded by!references/**references/v3-catalog/src/trigger/simple.tsis excluded by!references/**references/v3-catalog/src/trigger/stripe.tsis excluded by!references/**references/v3-catalog/src/trigger/subdir/another/byeWorld.tsis excluded by!references/**references/v3-catalog/src/trigger/subdir/helloWorld.tsis excluded by!references/**references/v3-catalog/src/trigger/subtasks.tsis excluded by!references/**references/v3-catalog/src/trigger/superjson.tsis excluded by!references/**references/v3-catalog/src/trigger/tags.tsis excluded by!references/**references/v3-catalog/src/trigger/taskHierarchy.tsis excluded by!references/**references/v3-catalog/src/trigger/taskTypes.tsis excluded by!references/**references/v3-catalog/src/trigger/triggerKitchenSink.tsis excluded by!references/**references/v3-catalog/src/trigger/usage.tsis excluded by!references/**references/v3-catalog/src/trigger/utils/cache.tsis excluded by!references/**references/v3-catalog/src/trigger/weird-file-names.tsis excluded by!references/**references/v3-catalog/src/trigger/wrangler.mtsis excluded by!references/**references/v3-catalog/src/trigger2/helloWorld.tsis excluded by!references/**references/v3-catalog/src/triggerWithLargePayload.tsis excluded by!references/**references/v3-catalog/src/utils/types.tsis excluded by!references/**references/v3-catalog/trigger.config.tsis excluded by!references/**references/v3-catalog/tsconfig.jsonis excluded by!references/**references/v3-catalog/wrangler/wrangler.tomlis excluded by!references/**
📒 Files selected for processing (4)
.vscode/launch.json(2 hunks)CONTRIBUTING.md(4 hunks)packages/cli-v3/CHANGELOG.md(2 hunks)packages/core/CHANGELOG.md(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-07-18T17:49:24.468Z
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-07-18T17:49:24.468Z
Learning: Applies to internal-packages/database/**/*.{ts,tsx} : We use prisma in internal-packages/database for our database interactions using PostgreSQL
Applied to files:
packages/core/CHANGELOG.md
📚 Learning: 2025-07-18T17:49:29.234Z
Learnt from: CR
PR: triggerdotdev/trigger.dev#0
File: .cursor/rules/executing-commands.mdc:0-0
Timestamp: 2025-07-18T17:49:29.234Z
Learning: Almost all commands in the monorepo should be executed using `pnpm run ...` from the root of the monorepo.
Applied to files:
CONTRIBUTING.md
🪛 LanguageTool
CONTRIBUTING.md
[grammar] ~93-~93: Ensure spelling is correct
Context: ...p First, make sure you are running the webapp according to the instructions above. Th...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[style] ~156-~156: This phrase is redundant. Consider using “inside”.
Context: ...ickup changes. Any changes to the files inside of the hello-world/src/trigger dir will ...
(OUTSIDE_OF)
[style] ~162-~162: Consider using a less common alternative to make your writing sound more unique and professional.
Context: ...ny of them accept an empty payload. 9. Feel free to add additional files in `hello-world/sr...
(FEEL_FREE_TO_STYLE_ME)
🪛 markdownlint-cli2 (0.17.2)
CONTRIBUTING.md
95-95: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
- GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
- GitHub Check: typecheck / typecheck
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (6)
.vscode/launch.json (1)
60-112: Switched v3-catalog cwd → hello-world consistently. LGTM.All five launch configs now point to references/hello-world and keep commands unchanged.
packages/cli-v3/CHANGELOG.md (3)
952-962: Sample DB name update to "hello-world" looks good.Matches the PR objective and keeps the rest of the snippet intact.
1589-1599: Second snippet DB rename also correct.Consistent with the earlier change.
1-1898: No lingering “v3-catalog” references found
Ran a repo-wide ripgrep search for\bv3-catalog\b(excluding build artifacts and lockfiles); no instances were detected.packages/core/CHANGELOG.md (2)
614-624: TypeORM example DB renamed to "hello-world" — OK.
1054-1064: Second TypeORM example updated consistently.
3 participants
No description provided.