fix: don't carry over the checkpoint ID when nack and requeuing#2502
fix: don't carry over the checkpoint ID when nack and requeuing#2502matt-aitken merged 1 commit intomainfrom
Conversation
|
|
Caution Review failedThe pull request is closed. WalkthroughA single change in internal-packages/run-engine/src/engine/index.ts updates the PENDING_EXECUTING branch of #handleStalledSnapshot. The call to RunEngine.runAttemptSystem.tryNackAndRequeue no longer includes the checkpointId field in its payload. Other arguments (run, environment, orgId, projectId, error, tx) remain as before. No exported or public declarations were altered. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
No description provided.