fix(engine): carry over completed waitpoints on PENDING_EXECUTING stalls

[ericallam]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5878127

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Warning

Rate limit exceeded

@ericallam has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 13 minutes and 41 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e36d78e and 5878127.

📒 Files selected for processing (2)

• internal-packages/run-engine/src/engine/index.ts (1 hunks)
• internal-packages/run-engine/src/engine/systems/runAttemptSystem.ts (3 hunks)

Walkthrough

• In engine/index.ts, within RunEngine.#handleStalledSnapshot’s requeue path for PENDING_EXECUTING and non-latest snapshots, the environment passed to tryNackAndRequeue now includes checkpointId (from latestSnapshot.checkpointId) and completedWaitpoints (from latestSnapshot.completedWaitpoints).
• In systems/runAttemptSystem.ts, startRunAttempt and tryNackAndRequeue method signatures are extended to accept an optional completedWaitpoints?: { id: string; index?: number }[].
• The completedWaitpoints parameter is propagated through requeue and start paths to preserve waitpoint completion state in new execution snapshots.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ea-branch-90

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}