chore(helm): align values-production-example.yaml with values.yaml#2606
Merged
nicktrn merged 1 commit intotriggerdotdev:mainfrom Oct 14, 2025
Merged
Conversation
- Move S3 credentials from secrets.objectStore to s3.auth - Update external PostgreSQL config to use databaseUrl/directUrl approach - Add existingSecret support for PostgreSQL with secretKeys - Add TLS configuration for external Redis - Add existingSecret support for Redis, ClickHouse and S3 - Add complete external S3 configuration example - Improve secure credential management documentation These changes align the production example file with the current values.yaml structure, making it easier to configure external services with better support for secret management.
|
Contributor
Walkthrough
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes align the production example file with the current values.yaml structure, making it easier to configure external services with better support for secret management.
✅ Checklist
Testing
Changelog
Screenshots
💯