Fix for .env issues when getting setup with the repo#2612
Conversation
matt-aitken
commented
Oct 17, 2025
- The .env.example was missing required Clickhouse values.
- A symlink was needed for .env from the root to the apps/webapp folder
- The .env.example was missing required Clickhouse values. - A symlink was needed for .env from the root to the apps/webapp folder
|
WalkthroughThe pull request adds Clickhouse configuration support by introducing three new environment variables in Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Rationale: The changes are lightweight configuration modifications with no runtime logic. Three files are affected—two configurations and one gitignore update—all following straightforward patterns. The modifications are homogeneous in nature (environment and build configuration only), requiring minimal contextual reasoning per file. Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.env.example (1)
16-19: Consider documenting Clickhouse variable purpose and cross-platform symlink notes.The three new Clickhouse variables are now present in
.env.example, addressing the PR objective. However, consider adding inline documentation for users unfamiliar with these variables. Additionally, the symlink approach used inapps/webapp/.envmay face limitations on Windows (requires Developer Mode or admin privileges), so consider documenting any setup requirements in a README or CONTRIBUTING guide.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.env.example(1 hunks)apps/webapp/.env(1 hunks)apps/webapp/.gitignore(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
- GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
- GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
- GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
- GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
- GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
- GitHub Check: typecheck / typecheck
- GitHub Check: Analyze (javascript-typescript)
🔇 Additional comments (2)
apps/webapp/.gitignore (1)
12-13: Gitignore negation pattern is correct.The negation pattern
!.envwill un-ignore the .env file so it can be tracked in Git. This is the right approach to ensure the symlink is not accidentally removed by gitignore cleaning. The comment is clear and helpful.However, this depends on Line 1 of
apps/webapp/.envbeing committed as a proper Git symlink—if that file is corrected to be a true symlink, this gitignore change will work as intended.apps/webapp/.env (1)
1-1: No issues found. The file is correctly committed as a Git symlink.The verification output confirms
120000mode, which is the correct Git object type for symlinks. The webapp will properly resolve this symlink to access the parent directory's.envfile as intended.