Dev concurrency limit by env (with optional global limit)

[matt-aitken]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 431c605

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request modifies environment variable handling for concurrent runs limits. The EnvironmentSchema field DEV_MAX_CONCURRENT_RUNS was changed from a required number with a default value of 25 to an optional number. Additionally, the logic for computing maxConcurrentRuns was updated to enforce a bounded constraint by taking the minimum between a global limit (with fallback to the environment's limit) and the environment's limit, replacing the previous direct assignment from the environment variable.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

The changes span two related files with mixed complexity: a schema validation change that alters the type signature of an exported entity, and a logic modification that introduces conditional fallback behavior with a min-based constraint. While the individual modifications are straightforward, understanding the relationship between the optional schema change and its corresponding usage requires careful verification to ensure the fallback logic properly handles the now-optional environment variable.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dev-concurrency-from-env

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3157b65 and 431c605.

📒 Files selected for processing (2)

• apps/webapp/app/env.server.ts (1 hunks)
• apps/webapp/app/routes/engine.v1.dev.config.ts (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[nicktrn]

👌