feat(test): upgrade mockito and optimize tests coverage #6117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlChaoCarl
changed the title
Contributor
|
Did the modification run successfully in the ARM environment of JDK17 during unit testing？ |
Contributor
Author
Yes, after the modifications, all the unit tests run normally under JDK 17. |
halibobo1205
reviewed
Jan 8, 2025
| privateMethod.setAccessible(true); | ||
| privateMethod.invoke(wallet, message, contractType, timeout); | ||
|
|
||
| assertTrue(true); |
Contributor
There was a problem hiding this comment.
What's the point here?
Contributor
Author
There was a problem hiding this comment.
This means that the unit test code runs here and there is no problem
Contributor
Author
There was a problem hiding this comment.
It can be removed. It's also fine to leave it here.
CodeNinjaEvan
approved these changes
Jan 9, 2025
lxcmyf
approved these changes
Jan 9, 2025
halibobo1205
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1.upgrade mockito
2.upgrade jacoco
3.optimize tests coverage
Why are these changes required?
This PR has been tested by:
Follow up
Extra details