feat(command): change newly added "--keystore" parameter to "--keystore-factory" #6446
+7
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
317787106
approved these changes
Sep 10, 2025
halibobo1205
force-pushed
the
feat/command_opt
branch
from
2aa702a to
76bbaf5
Compare
BlueHoopor
requested changes
Sep 11, 2025
Contributor
BlueHoopor
left a comment
BlueHoopor
left a comment
There was a problem hiding this comment.
The parameter names should maintain a consistent naming style. It should be changed from "--keystoreFactory" to "--keystore-factory".
halibobo1205
force-pushed
the
feat/command_opt
branch
2 times, most recently
from
812259a to
ae5d63e
Compare
halibobo1205
changed the title
halibobo1205
changed the title
halibobo1205
force-pushed
the
feat/command_opt
branch
from
ae5d63e to
f403110
Compare
Contributor
Author
done. |
halibobo1205
changed the title
lvs0075
approved these changes
Sep 12, 2025
Federico2014
approved these changes
Sep 12, 2025
0xbigapple
reviewed
Sep 12, 2025
common/src/main/java/org/tron/common/parameter/CommonParameter.java
Outdated
Show resolved
Hide resolved
…actory" The "--keystore" parameter name could be misleading, as it typically refers to encrypted key storage files or wallets, while this parameter actually runs a KeystoreFactory. The new name "--keystore-factory" makes the parameter's purpose more explicit and avoids potential confusion.
halibobo1205
force-pushed
the
feat/command_opt
branch
from
f403110 to
38679b7
Compare
bladehan1
approved these changes
Sep 12, 2025
0xbigapple
approved these changes
Sep 12, 2025
kuny0707
approved these changes
Sep 12, 2025
BlueHoopor
approved these changes
Sep 12, 2025
halibobo1205
added a commit
to halibobo1205/java-tron
that referenced
this pull request
Oct 14, 2025
…actory" (tronprotocol#6446) The "--keystore" parameter name could be misleading, as it typically refers to encrypted key storage files or wallets, while this parameter actually runs a KeystoreFactory. The new name "--keystore-factory" makes the parameter's purpose more explicit and avoids potential confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename
--keystoreparameter to--keystore-factory, pre-PR: #6397.Why are these changes required?
The
--keystoreparameter name could be misleading, as it typically refers to encrypted key storage files or wallets, while this parameter actually runs a KeystoreFactory. The new name--keystore-factorymakes the parameter's purpose more explicit and avoids potential confusion.This PR has been tested by:
Follow up
Extra details