feat(exit): throw TronError if JDK does not support #6455
Conversation
| AnsiConsole.systemUninstall(); | ||
| throw new TronError(e, TronError.ErrCode.JDK_VERSION); | ||
| } | ||
| clearParam(); // reset all parameters to avoid the influence in test |
There was a problem hiding this comment.
The method name throwIfUnsupportedJavaVersion can be modified as checkJdkCompatible ?
What's the output of three lines related with AnsiConsole ?
There was a problem hiding this comment.
throwIfUnsupportedJavaVersion is the more accurate and intention-revealing name because it clearly communicates that the method will throw an exception if the condition is not met.
This error will appear on the console to alert the user, rather than being quietly recorded in the log files.
There was a problem hiding this comment.
If you want to show this infomation in console, this AnsiConsole should be placed in ExitManager, so all TronError has the same action.
There was a problem hiding this comment.
To avoid confusion caused by silent execution when using -h or -v flags, errors are explicitly logged to the console in this context. Console output is not required for errors in other scenarios.
| "1.8 ", getOsArch(), javaSpecificationVersion())); | ||
| "Java %s is required for %s architecture. Detected version %s", "1.8", | ||
| getOsArch(), javaSpecificationVersion())); | ||
| } |
There was a problem hiding this comment.
Why not write Java 1.8 directly ?
There was a problem hiding this comment.
I believe either style is fine.
halibobo1205
force-pushed
the
arch/arm64
branch
from
d79e879 to
b582eea
Compare
halibobo1205
force-pushed
the
arch/arm64
branch
from
b582eea to
f1d1b4a
Compare
7 participants
What does this PR do?
Replace the UnsupportedOperationException with TronError if the JDK does not support.
Why are these changes required?
This PR has been tested by:
Follow up
Extra details