Merged
Conversation
Contributor
|
This repo should never alter While you're there, to change but obviously that will break RD's code the next time they upgrade the package version |
Member
Author
|
I'll create a PR in the app repo as well then can merge both at the same time |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the new PUT API to be the 'explicit identification API' and moved the old one to just a 'create user API'. Think that makes more sense.
I also think we should change the SDK method name from
.upsert()to.identify()to match the use case better. But i'll need you to change the SDK generation code for that.