72 align coding standards and naming #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated function names from camelCase to snake_case to follow official PHP coding standards for function naming conventions. Breaking Changes: - spawnWith() → spawn_with() - awaitAnyOrFail() → await_any_or_fail() - awaitFirstSuccess() → await_first_success() - awaitAllOrFail() → await_all_or_fail() - awaitAll() → await_all() - awaitAnyOfOrFail() → await_any_of_or_fail() - awaitAnyOf() → await_any_of() - currentContext() → current_context() - coroutineContext() → coroutine_context() - currentCoroutine() → current_coroutine() - rootContext() → root_context() - getCoroutines() → get_coroutines() - gracefulShutdown() → graceful_shutdown() Changes: - Updated async.stub.php with new function names - Regenerated async_arginfo.h - Updated PHP_FUNCTION declarations in async.c - Updated all 137 test files with new function names and use statements - Added breaking change documentation to CHANGELOG.md Reference: https://github.com/php/policies/blob/main/coding-standards-and-naming.rst
There was a problem hiding this comment.
Pull request overview
This pull request aligns the codebase with PHP coding standards by renaming functions from camelCase to snake_case. This is a breaking change that affects all async function names.
Key Changes:
- Renamed 13 async functions to use snake_case convention (e.g.,
awaitAll()→await_all(),spawnWith()→spawn_with()) - Updated all test files (160+ files) to use the new function names
- Updated C implementation files (async.c, async_arginfo.h, async.stub.php) with new function names
- Applied code formatting improvements to scheduler.c and libuv_reactor.c
- Documented breaking changes in CHANGELOG.md
Reviewed changes
Copilot reviewed 143 out of 144 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| async.stub.php | Updated PHP stub definitions with new snake_case function names |
| async_arginfo.h | Regenerated argument info with updated function signatures |
| async.c | Renamed PHP_FUNCTION declarations; minor brace placement issue found |
| scheduler.c | Code formatting improvements for multi-line conditionals |
| libuv_reactor.c | Minor formatting fixes and comment correction |
| CHANGELOG.md | Comprehensive documentation of all renamed functions |
| tests/* (160+ files) | Updated all test files to use new function names in imports and calls |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.