[pull] master from ruby:master#372
Merged
pull[bot] merged 5 commits intoturkdevops:masterfrom Oct 17, 2025
Merged
Conversation
#8572. Specifically: * Correctly pass command line arguments to CMake * Call CMake twice - once to configure a project and a second time to build (which is the standard way to use CMake). This fixes the previously incorrect assumption that CMake generates a Make file. * Update the tests to specify a CMake minimum version of 3.26 (which is already two years old). 3.26 is a bit arbritary but it aligns with Rice, and updates from the ancient 3.5 version being used (which CMake generates a warning message saying stop using it!) * Update the CMake call to use CMAKE_RUNTIME_OUTPUT_DIRECTORY and CMAKE_LIBRARY_OUTPUT_DIRECTORY to tell CMake to copy compiled binaries to the a Gem's lib directory. Note the updated builder took inspiration from the Cargo Builder, meaning you first create an instance of CmakeBuilder versus just calling class methods. ruby/rubygems@9e248d4679
The following errors happened at the actions/setup-python step. https://github.com/ruby/ruby/actions/runs/18229870239 > The version '3.x' with architecture 's390x' was not found for Ubuntu 24.04. > The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json > The version '3.x' with architecture 'ppc64' was not found for Ubuntu 24.04. > The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json After skipping the actions/setup-python step, the following errors also happened at the actions/setup-java step. https://github.com/ruby/ruby/actions/runs/18355975425?pr=14721 > make-ibm (check, ubuntu-24.04-ppc64le) > Could not find satisfied version for SemVer '17'. > make-ibm (check, ubuntu-24.04-s390x) > The process '/usr/bin/bash' failed with exit code 1 > make-ibm (check, ubuntu-24.04-s390x) > Process completed with exit code 127. To fix the errors, I started using the Java distribution semeru (IBM Semeru Runtime Open Edition) on the ppc64le/s390x cases. You can see the following page for the details of the Java distribution semeru. https://github.com/actions/setup-java?tab=readme-ov-file#supported-distributions https://github.com/actions/setup-java/blob/ead9eaa3cfe0b0fc2fa749519ae09c3d4f4080b0/src/distributions/semeru/installer.ts#L20-L27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )