[pull] master from ruby:master#797
Merged
pull[bot] merged 6 commits intoturkdevops:masterfrom Feb 21, 2026
Merged
Conversation
This reverts commit d256629.
This test has been failing intermittently on multiple CI platforms (Debian 13, RHEL 9/10, Ubuntu aarch64) with heap_allocated_pages growing from 100 to 130, or major_gc_count incrementing by 1. Failing run: https://rubyci.s3.amazonaws.com/ubuntu/ruby-master/log/20260220T001003Z.fail.html.gz The test uses assert_separately, so test ordering is not a factor. In failing runs sweep_slots (27,386) lands within ~1,200 of min_free_slots (28,652) after warmup. I've been unable to reliably replicate this. However, when looking at the failures messages all failing runs total_freed_pages is 0: pages are not being freed and reallocated in a cycle. This is distinct from [Bug #18929] where pages cycled between allocation and the tomb heap. Since total_freed_pages == 0 already guards against the thrashing from [Bug #18929], relax heap_allocated_pages to assert_in_epsilon (50% tolerance) and drop major_gc_count which follows from the same marginal threshold.
Use keyword arguments and extract repeated regexps as constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )