Nav2 changed how use_sim_time is set, should not be in yaml#564
Merged
hilary-luo merged 1 commit intojazzyfrom Mar 12, 2025
Merged
Nav2 changed how use_sim_time is set, should not be in yaml#564hilary-luo merged 1 commit intojazzyfrom
hilary-luo merged 1 commit intojazzyfrom
Conversation
civerachb-cpr
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Between Humble and Jazzy, a change was made in how use_sim_time is set in the Nav2 launch file. Now if we have it in the yaml, that actually overrides what is passed in to the launch file.
See ros-navigation/navigation2@7703c81