Skip to content

fix(synonyms): add upsert method to SynonymSet #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewjtait wants to merge 1 commit into
base: master
Choose a base branch
from
+14 −0
Open

fix(synonyms): add upsert method to SynonymSet #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/typesense/synonym_set.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ def initialize(synonym_set_name, api_call)
@api_call = api_call
end

def upsert(params)
@api_call.put(endpoint_path, params)
end

def retrieve
@api_call.get(endpoint_path)
end
Expand Down
10 changes: 10 additions & 0 deletions spec/typesense/synonym_set_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,16 @@
# Ignore errors if already deleted
end

describe '#upsert' do
it 'creates a synonym set and returns it' do
skip('SynonymSets is only supported in Typesense v30+') unless typesense_v30_or_above?

result = synonym_set.upsert(synonym_set_data)

expect(result['items']).to eq(synonym_set_data['items'])
end
end

describe '#retrieve' do
it 'returns the specified synonym set' do
skip('SynonymSets is only supported in Typesense v30+') unless typesense_v30_or_above?
Expand Down