fix: allow local embeddings in EmbeddingStrategy #1697
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1658
The
_get_embedding_llm_config_dictmethod was always returning a fallback OpenAI configuration when noembedding_llm_configwas provided. This made local sentence-transformers embeddings unreachable when usingAdaptiveCrawler.List of files changed and why
crawl4ai/adaptive_crawler.py- Changed_get_embedding_llm_config_dictto returnNoneinstead of a fallback dict, allowingget_text_embeddings()to use the local sentence-transformers path when the user intends to use local embeddingstests/unit/test_embedding_strategy_local.py- Added unit test to verify the fixHow Has This Been Tested?
_get_embedding_llm_config_dict()returnsNonewhen no config providedChecklist: