History Comment Sync #170
Open
History Comment Sync #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisPenner
force-pushed
the
cp/comment-download
branch
from
25be58a to
90eef61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This implements the first iteration of History Comment Sync.
Implementation notes
This first iteration uses a somewhat naive interactive comment sync which consists of a linear scan of all comments on the spine of the provided causal, followed by negotiating which of the comments and revisions each side needs.
Interesting/controversial decisions
This may prove to be slow on some branches, we have a follow up planned, but it involves implementing Merkle Search Trees which are not trivial to implement efficiently.
Test coverage
Loose ends
See