fix: revert replace docker overview table with web component (7.3+) #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughThis pull request performs a comprehensive cleanup of the codebase by removing substantial portions of Docker-related functionality, complex organizer mutations, logging/stats/Tailscale integrations, notification deduplication logic, and numerous frontend components and composables. Changes span environment configurations, GraphQL schema, backend services, frontend components, and utility functions. Changes
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Areas requiring extra attention:
Possibly related PRs
Suggested reviewers
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (152)
Comment |
elibosley
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ObjectType, | ||
| registerEnumType, | ||
| } from '@nestjs/graphql'; | ||
| import { Field, ID, Int, ObjectType, registerEnumType } from '@nestjs/graphql'; |
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
In general, unused imports should be removed from the import statement to avoid confusion and keep the code clean. Here, the ID symbol from @nestjs/graphql is not referenced anywhere in this file, while the other imported symbols are used. The best fix is to simply remove ID from the named imports, leaving the rest of the import intact.
Concretely, in api/src/unraid-api/graph/resolvers/docker/docker.model.ts, adjust the first line so that ID is no longer part of the destructuring import from @nestjs/graphql. No other lines or imports need to be touched, and no new methods or definitions are required.
Suggested changeset
1
api/src/unraid-api/graph/resolvers/docker/docker.model.ts
| @@ -1,4 +1,4 @@ | ||
| import { Field, ID, Int, ObjectType, registerEnumType } from '@nestjs/graphql'; | ||
| import { Field, Int, ObjectType, registerEnumType } from '@nestjs/graphql'; | ||
|
|
||
| import { Node } from '@unraid/shared/graphql.model.js'; | ||
| import { GraphQLBigInt, GraphQLJSON, GraphQLPort } from 'graphql-scalars'; |
Copilot is powered by AI and may make mistakes. Always verify output.
| @@ -1,30 +1,20 @@ | |||
| import { CACHE_MANAGER } from '@nestjs/cache-manager'; | |||
| import { Inject, Injectable, Logger } from '@nestjs/common'; | |||
| import { Inject, Injectable, Logger, OnModuleInit } from '@nestjs/common'; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 month ago
To fix an unused import, the best approach is simply to remove the unused symbol from the import statement, leaving the rest of the imports intact. This avoids any behavior changes, since unused type imports have no runtime effect. In this file, only OnModuleInit is unused; Inject, Injectable, and Logger remain necessary.
Concretely, in api/src/unraid-api/graph/resolvers/docker/docker.service.ts, edit the import from @nestjs/common on line 2 to remove OnModuleInit from the destructuring list. No other code changes or additional imports are needed.
Suggested changeset
1
api/src/unraid-api/graph/resolvers/docker/docker.service.ts
| @@ -1,5 +1,5 @@ | ||
| import { CACHE_MANAGER } from '@nestjs/cache-manager'; | ||
| import { Inject, Injectable, Logger, OnModuleInit } from '@nestjs/common'; | ||
| import { Inject, Injectable, Logger } from '@nestjs/common'; | ||
| import { readFile } from 'fs/promises'; | ||
|
|
||
| import { type Cache } from 'cache-manager'; |
Copilot is powered by AI and may make mistakes. Always verify output.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1853 +/- ##
==========================================
+ Coverage 46.43% 52.94% +6.51%
==========================================
Files 954 868 -86
Lines 59788 50099 -9689
Branches 5545 5091 -454
==========================================
- Hits 27764 26527 -1237
+ Misses 31905 23497 -8408
+ Partials 119 75 -44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This plugin has been deployed to Cloudflare R2 and is available for testing. |
elibosley
pushed a commit
that referenced
this pull request
Dec 19, 2025
🤖 I have created a release *beep* *boop* --- ## [4.29.1](v4.29.0...v4.29.1) (2025-12-19) ### Bug Fixes * revert replace docker overview table with web component (7.3+) ([#1853](#1853)) ([560db88](560db88)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1764
Summary by CodeRabbit
Feature Removal
UI Changes
Dependencies
✏️ Tip: You can customize this high-level summary in your review settings.