Downloading sealights agent from 'customAgentUrl' #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ursulaflorianczyk
force-pushed
the
supporting-customAgentUrl
branch
from
49812b4 to
557d2aa
Compare
gregoryfuta
approved these changes
Jan 9, 2024
| build_session_id: | ||
| lab_id: | ||
| proxy: | ||
| auto_upgrade: false |
There was a problem hiding this comment.
Wouldn't it break backward compatibility?
Owner
Author
There was a problem hiding this comment.
We had defined 'auto_upgrade' parameter, but in buildpack code we checked if 'enable_upgrade' is set in app configuration. I removed 'auto_upgrade' parameter and added definition for 'enable_upgrade'.
It can affect present configurations in two ways:
- if it happened that customer has configured 'enable_upgrade': true in app configuration then this parameter will start working now
- if customer has configured 'auto_upgrade' in app configuration then he will start to see warning [ConfigurationUtils] WARN User config value for 'auto_upgrade' is not valid, existing property not present. The actual value of this parameter was ignored by our code anyway.
| download('custom', custom_download_uri, name) do |file| | ||
| with_timing "Expanding #{name} to #{target_directory.relative_path_from(@droplet.root)}" do | ||
| FileUtils.mkdir_p target_directory | ||
| shell "unzip -qq #{file.path} -d #{target_directory} 2>&1" |
Owner
Author
There was a problem hiding this comment.
I just used the fragment of code from download_zip from base_component.rb (I could not call it because this function was overwritten in versioned_dependency_component.rb)
ursulaflorianczyk
force-pushed
the
supporting-customAgentUrl
branch
from
557d2aa to
9fb55a7
Compare
ChrisDekarz
reviewed
Jan 9, 2024
ChrisDekarz
approved these changes
Jan 9, 2024
ursulaflorianczyk
force-pushed
the
supporting-customAgentUrl
branch
from
d1dfd9d to
8c1d937
Compare
ChrisDekarz
approved these changes
Jan 11, 2024
gregoryfuta
approved these changes
Jan 11, 2024
gregoryfuta
left a comment
gregoryfuta
left a comment
There was a problem hiding this comment.
If I understand the Ruby syntax corectly... :D
ursulaflorianczyk
force-pushed
the
supporting-customAgentUrl
branch
2 times, most recently
from
4a3692d to
3457554
Compare
Added support for the new parameter both from app configuration and sealights user-provided service
Searching for jar which name starts with 'sl-test-listener' in zip downloaded from customAgentUrl
Overwrite sl.enableUpgrade to false when agent is downloaded from customAgentUrl
'enable_upgrade' parameter name fix in config yml file ('auto_upgrade' was not used in sealights framework)
Modified adding system property sl.tag to contain buildpack version
ursulaflorianczyk
force-pushed
the
supporting-customAgentUrl
branch
from
3457554 to
1a3aa19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for the new parameter both from app configuration and sealights user-provided service
Searching for jar which name starts with 'sl-test-listener' in zip downloaded from customAgentUrl
Overwrite sl.enableUpgrade to false when agent is downloaded from customAgentUrl
'enable_upgrade' parameter name fix in config yml file ('auto_upgrade' was not used in sealights framework)