tail: fix -F to properly track symlinks with changing targets #10158
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The new integration test appears to be failing on some platforms, moving back to draft to investigate |
|
GNU testsuite comparison: |
Contributor
|
Hey, IIrc the has appeared message is sometimes random. Even with gnu utils |
ChrisDryden
force-pushed
the
tail-follow-symlink
branch
from
ecff664 to
4971fa7
Compare
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When investigating the symlink test, it seemed that it was expecting very similar behaviour to the way that we track orphan files. Did some testing around to see if we could place the symlink files that have broken links to the orphan tracker in the event loop when unable to access the metadata to reuse the logic. Seemed to match the behaviour that the gnu test was expecting.