yes, timeout: adding pipeline signal handlers #10166
Open
+98
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Somehow every SELinux test failed here |
Collaborator
Author
|
I think I might take the approach of splitting this to first deploy the timeout and yes fixes and then make the change to revert the overrides. |
Collaborator
Author
|
I'm discovering how much the timeout utility has changed between now and the launch of 9.9, its quite different when it comes to signal handling |
ChrisDryden
force-pushed
the
fix-sigpipe-7252
branch
from
b502626 to
ad74ceb
Compare
ChrisDryden
changed the title
Collaborator
Author
|
Getting this working is going to be a very complex issue when it comes to ordering the PR's. I have a working branch that implements timeout in the same way that the latest master in coreutils works, but its involves quite a bunch of changes so I'm hoping to get this one in before I make that PR. |
|
GNU testsuite comparison: |
This was referenced Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bunch of deviation from our implementation of Yes and Timeout and the gnu version and a long time ago, the gnu tests were patched so that for some tests it used the system yes and timeout. Now that we have proper signal handling implementations for our utilities we can revert this change and also see the gaps in our yes and timeout implementation and the gnu implementation by removing the overrides.
One key area that this will fail is the env-signal-handler test. It was relying on a bunch on non-implemented functionality in timeout that we need to implement for this test to pass. Mainly related to the non standard posix signals like RTMAX/RTMIN which is described here: #6218
UPDATE:
There are still issues with our implementation of timeout, so even though this brings us closer to the GNU implementation, its still not enough to remove the GNU patch. Will handle that in a later PR once timeout is in a better state.