Skip to content

Conversation

@van-sprundel
Copy link
Contributor

@van-sprundel van-sprundel commented Jan 12, 2026

I thought this would be an easier fix, but there's a lot that I did not understand from system file mounts. For example, what "over mounting" is and when a file system is over mounted.

ramones@fedora:~/git/coreutils$ diff <(df --all 2>/dev/null | sort) <(./target/release/df --all 2>/dev/null | sort) | head -20
20,21d19
< nsfs                   -         -         -    - /run/docker/netns/f28327792c0d
< overlay                -         -         -    - /var/lib/docker/overlay2/852ac0d36c2d3d13e4bcf9aad8d58cbb182c2b3ba289671e36138b7ce86ed7c2/merged
27c25
< systemd-1              -         -         -    - /proc/sys/fs/binfmt_misc
---
> systemd-1              0         0         0    - /proc/sys/fs/binfmt_misc
ramones@fedora:~/git/coreutils$ ./target/release/df --all 2>/dev/null | grep binfmt_misc
systemd-1              0         0         0    - /proc/sys/fs/binfmt_misc
binfmt_misc            0         0         0    - /proc/sys/fs/binfmt_misc

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch from becb0ee to 990f378 Compare January 12, 2026 09:06
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/df/over-mount-device. tests/df/over-mount-device is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch from 990f378 to 02a706e Compare January 12, 2026 16:55
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/df/over-mount-device. tests/df/over-mount-device is passing on 'main'. Maybe you have to rebase?

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch 2 times, most recently from 990f378 to f32abb3 Compare January 12, 2026 17:45
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/df/over-mount-device. tests/df/over-mount-device is passing on 'main'. Maybe you have to rebase?

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch from f32abb3 to 7faf1db Compare January 12, 2026 18:22
@github-actions
Copy link

GNU testsuite comparison:

GNU test failed: tests/df/over-mount-device. tests/df/over-mount-device is passing on 'main'. Maybe you have to rebase?
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch 4 times, most recently from dd80c03 to 1efd049 Compare January 12, 2026 21:50
@github-actions
Copy link

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch from 1efd049 to a59f495 Compare January 13, 2026 08:30
@van-sprundel
Copy link
Contributor Author

van-sprundel commented Jan 13, 2026

Seems like this test keeps failing due to no space left when cleaning up. Not sure if I can do something about this

https://github.com/uutils/coreutils/actions/runs/20926906984/job/60127207847

ah its not just me

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

@van-sprundel van-sprundel force-pushed the fix-wrong-mount-dev-id branch from a59f495 to 8daf10a Compare January 13, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant