nice -n huge_num true #10213

oech3 · 2026-01-13T10:48:20Z

github-actions · 2026-01-13T11:29:03Z

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

src/uu/nice/src/nice.rs

github-actions · 2026-01-13T15:54:35Z

GNU testsuite comparison:

Skipping an intermittent issue tests/shuf/shuf-reservoir (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/sort/sort-stale-thread-mem (passes in this run but fails in the 'main' branch)

tests/by-util/test_nice.rs

github-actions · 2026-01-14T00:59:09Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tty/tty-eof (passes in this run but fails in the 'main' branch)

src/uu/nice/src/nice.rs

sylvestre · 2026-01-17T16:19:07Z

src/uu/nice/src/nice.rs

-                        translate!("nice-error-invalid-number", "value" => nstr.clone(), "error" => e),
-                    ));
+                    // clamp huge values
+                    let trimmed = nstr.trim();


i think moving it into a function could help with readability

Is this operation duplicated at somethere?

tests/by-util/test_nice.rs

codspeed-hq · 2026-01-17T16:49:40Z

Merging this PR will degrade performance by 26.25%

❌ 8 regressed benchmarks
✅ 274 untouched benchmarks
⏩ 38 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
❌	Memory	`sort_mixed_data[500000]`	22.5 MB	27.2 MB	-17.15%
❌	Memory	`sort_ascii_only[500000]`	22.2 MB	28.3 MB	-21.74%
❌	Memory	`sort_long_line[160000]`	724.4 KB	982.3 KB	-26.25%
❌	Memory	`sort_accented_data[500000]`	22.1 MB	28.3 MB	-21.78%
❌	Memory	`sort_key_field[500000]`	45.8 MB	51.8 MB	-11.46%
❌	Memory	`cp_large_file[16]`	107.6 KB	120 KB	-10.34%
❌	Memory	`du_wide_tree[(5000, 500)]`	1.2 MB	1.3 MB	-5.39%
❌	Simulation	`cp_large_file[16]`	369.8 µs	382.4 µs	-3.3%

_{Comparing oech3:nice-huge (34c2172) with main (799de29)}

38 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2026-01-17T18:00:34Z

GNU testsuite comparison:

GNU test failed: tests/tail/follow-name. tests/tail/follow-name is passing on 'main'. Maybe you have to rebase?

github-actions · 2026-01-17T20:59:30Z

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

sylvestre · 2026-01-17T21:39:42Z

tests/by-util/test_nice.rs

+
+#[test]
+fn test_sign_middle() {
+    new_ucmd!().args(&["-n", "-2+4", "true"]).fails();


What is the error message?

github-actions · 2026-01-17T21:45:41Z

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

github-actions · 2026-01-17T22:03:19Z

GNU testsuite comparison:

Congrats! The gnu test tests/basenc/bounded-memory is now passing!

sylvestre · 2026-01-17T22:46:58Z

src/uu/nice/src/nice.rs

            format!("getpriority: {}", Error::last_os_error()),
        ));
    }
+    let nice_bound = 50;


Hard-coded magic number 50 should be a named constant like MAX_NICE_OVERFLOW or similar

sylvestre · 2026-01-17T22:47:17Z

tests/by-util/test_nice.rs

+
+#[test]
+fn test_nice_huge_negative() {
+    new_ucmd!().args(&["-n", "-9999999999", "true"]).succeeds(); // permission denied


Negative overflow test should verify actual niceness value is clamped to expected bound

github-actions · 2026-01-18T04:52:49Z

GNU testsuite comparison:

Skip an intermittent issue tests/shuf/shuf-reservoir (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/sort/sort-stale-thread-mem (fails in this run but passes in the 'main' branch)

oech3 changed the title ~~Nice huge~~ nice -n huge_num true Jan 13, 2026

oech3 force-pushed the nice-huge branch 2 times, most recently from eec8ae2 to ae0c818 Compare January 13, 2026 10:50

oech3 mentioned this pull request Jan 13, 2026

tests: nice -n 9999999999999999999999999999999999999999999999999999999999999… coreutils/coreutils#170

Closed

sylvestre reviewed Jan 13, 2026

View reviewed changes

src/uu/nice/src/nice.rs Outdated Show resolved Hide resolved

oech3 force-pushed the nice-huge branch 2 times, most recently from 4ce1311 to 7a75ddd Compare January 13, 2026 15:42

oech3 force-pushed the nice-huge branch from 7a75ddd to d7f458d Compare January 13, 2026 16:11

sylvestre reviewed Jan 13, 2026

View reviewed changes

tests/by-util/test_nice.rs Show resolved Hide resolved

oech3 force-pushed the nice-huge branch 2 times, most recently from fae9d13 to 0166306 Compare January 14, 2026 00:47